Fixed sign in compositeArea calc (polygons with holes now calc OK) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of Allowable Mixing Zone area (+Depomod/+Layout/Site.m) was incorrect. Pen layouts with large spacing can have "holes" within the overall area. The "compositeArea" function attempted to deal with this scenario but added the areas of the holes to (rather than subtracted them from) the area of the external polygon.
The code makes use of Matlab's "polyarea" function which gives the same result regardless of whether polygon nodes are specified clockwise or anticlockwise.
With the suggested change the mixing zone area should be correct and match with that given by Depomod itself.