Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimum required for ros2 into CMakeLists.txt #23

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Fix minimum required for ros2 into CMakeLists.txt #23

wants to merge 1 commit into from

Conversation

mosfet80
Copy link

humble use c++17
cmake <3.8 is deprecated

@mosfet80
Fix minimum required for ros2 into CMakeLists.txt
60d06e6 
humble use c++17
cmake <3.8 is deprecated
@wxmerkt
Copy link
Member

wxmerkt commented Jun 25, 2024

Do we have build failures due to this?

@mosfet80
Copy link
Author

mosfet80 commented Jul 9, 2024

ros2 requirements:
https://docs.ros.org/en/humble/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html

@wxmerkt
Copy link
Member

wxmerkt commented Jul 14, 2024

Given that there is no code being built (just headers installed), we could also remove the lines for the C++ standard entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosfet80 @wxmerkt