Aes keysize update #1054
Open
Aes keysize update #1054
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gb-8
reviewed
Jan 6, 2025
| @@ -60,7 +60,7 @@ Aes GetCryptoProvider(byte[]? iv = null) | |||
| var provider = Aes.Create(); | |||
| provider.Mode = CipherMode.CBC; | |||
| provider.Padding = PaddingMode.PKCS7; | |||
| provider.KeySize = 128; | |||
| provider.KeySize = 256; | |||
There was a problem hiding this comment.
I was expecting you'd need to modify the key generation to use a 32 byte key also.
There was a problem hiding this comment.
setting this key size doesn't do anything by itself, when you set the key, it'll then set the keysize 😂
Maybe steal the Calamari version: https://github.com/OctopusDeploy/Calamari/pull/1405/files#diff-67547aea4be6e349d7da9a9a3f90d83a795171716b038c406aff1ff8d4c8d18b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.
Background
Results
Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)
Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)
See How we use GitHub Issues (including this flowchart
Before
After
How to review this PR
Quality ✔️
Pre-requisites