Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync dotnet-install.ps1 to remove azureedge.net #1056

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhysparry
Copy link
Contributor

Background

The azureedge.net domain is no longer used to provide the .NET SDK. This PR synchronises our forked version of the dotnet-install.ps1 script with the upstream version.

Results

  • References to azureedge.net have been removed
  • The NoCdn parameter of the script has been removed (as per upstream)

How to review this PR

This PR primarily changes the old references to domains that are no longer used to serve the dotnet SDK. This keeps the changes relatively constrained following the most recent synchronisation:

To compare with the current version upstream, the following command can be run (tested in bash):

diff --color=auto --strip-trailing-cr <(curl --location https://dot.net/v1/dotnet-install.ps1) dotnet-install.ps1

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry requested a review from a team as a code owner January 16, 2025 02:48
@rhysparry rhysparry force-pushed the sast/sc-101376/remove-azureedge-net branch from 5ef8885 to 6a44ed9 Compare January 22, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants