Fixing bug where script output would appear twice in task logs

[sburmanoctopus]

Background

While testing out the new event driven tentacle client in Octopus Server, we found that E2E tests were failing because log output was coming through twice.

Results

Before

When the event driven tentacle client work was done, it maintained a quirk with script service V1. The quirk was that calling "Complete Script" could return output. This output had to be written to the Octopus Server task log, but only script service V1 was doing this.

During the refactor, we ended up maintaining the output logging after "Complete Script", but it was put in a common place which will get run for all service types, not just V1.

After

Where we call OnScriptStatusResponseReceived after we "Complete Script" is the correct location. However, if we do not receive any output (e.g. if we are the V2 or K8s script service), then we simply do not output the results.

We enhanced a test to prove the flaw, and then fixed the test by solving the issue.

How to review this PR

Quality ✔️

Pre-requisites

• I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
• I have considered informing or consulting the right people, according to the ownership map.
• I have considered appropriate testing for my change.