Dont use globals for the tc metrics settings #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I had success all during testing for the metrics shipping, but as soon as I merged and used the prod one, it stopped working.
Interestingly, it started working after teamcity was restarted due to cluster upgrade. This suggests to me that the global was getting into a bad state due to concurrency.
This is wise anyway, as we want to avoid the use of the global properties, as it allows metrics per project.
[sc-96078]
Results
We now:
add an attribute to the metric, so we can see what build it relates tothis was done in Log build id with metrics #348.After
How to review this PR
Pre-requisites