Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember scheduled time in the edit-form time picker - attempt #3018

Closed
wants to merge 1 commit into from

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Nov 7, 2023

Changes:

  • Remember the schduled livestream date in the edit form DateTimePicker
  • Remember the scheduled video release date in the edit form DateTimePicker
  • If livestream's scheduled time has passed, default to "Anytime" in edit

Not sure if I'm missing something, as I just followed what the TODO comment in old code said. But I didn't found this causing any issues.

@infinite-persistence
Copy link
Collaborator

infinite-persistence commented Nov 7, 2023

  • I think we need to replicate the removed logic, i.e. only set the release time if it was isScheduled, or ensure it's only done for specific cases.
    • Because for other forms like unlisted, releaseTime need to be undefined at the beginning of Edit to differentiate whether the user entered something or not (see const PAYLOAD = for reference on userEnteredTs).
  • Other than that, it looks good in a glance.

The general thought process was:

  • the original values can always be queried from claimToEdit -- single source of truth
  • publishData.releaseTime is a UI state that reflects user-entered data. If user did not touch, it remains undefined.
  • With that, the payload generator has enough data to construct the SDK payload based on various situations.

@keikari
Copy link
Contributor Author

keikari commented Nov 10, 2023

Will forget about this for now.

Original reason was, that an user had issues with scheduled stream start time changing randomly. Thought they might have been just confused by the default time in the edit form, but turned out it's not that.
(Don't know what it is exactly, yet)

@keikari keikari closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants