Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction and redirection #3039

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Correction and redirection #3039

merged 3 commits into from
Jan 16, 2024

Conversation

es-socrates
Copy link
Collaborator

Change of data in the verification request card for Discord.

</p>
<p>{__('You will be asked to provide proof of identity.')}</p>
<p>{__('Verification requests can take a few hours to be approved.')}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelmitnick please add this to the app-strings.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant "'Verification requests can take a few hours to be approved." string to app-strings.json. Let me know if you wanna take another shot.

Notice you also added back: 'You will be asked to provide proof of identity.' - that's not what I meant, and probably can be removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's right, the app-strings.json was not edited. I'll correct it, sorry.

label={__('Join the Odysee Rewards Discord')}
/>
}
actions={<Button href="https://chat.odysee.com" button="primary" label={__('Join our Discord')} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can just remove this button

Copy link
Collaborator Author

@es-socrates es-socrates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes and compiled check. @tzarebczan

@tzarebczan
Copy link
Contributor

thank you, lgtm!

@tzarebczan tzarebczan merged commit 91ad6b8 into master Jan 16, 2024
2 checks passed
@tzarebczan tzarebczan deleted the socrates-dev branch January 16, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants