Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: #2895
New behavior:
-queue pauses playing on end of the last video
-the second item from the queue doesn't start playing in middle of other playlists
Seems that a second
onVideoEnded
function gets attached to the player, when a second queue item is added. (Doesn't happen with following video adds)And one of those sticked around, and got called when not wanted. (I didn't quite understood how this exactly worked.)
Clearing
onEnded
s before adding a new one, seems to fix the behavior.Also clearing them didn't seem to break anything. Looping and shuffle also kept working the same than before.