Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sync deletion warnings #3054

Merged

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Feb 5, 2024

-Show warning about synced channels on account deletion, if user has any synced channels
-On channel deletion, don't show the warning about synced channels, if user doesn't have any synced channels
-selectHasYoutubeChannels used to always return true due to it working previously like this: Number.isInteger(youtubeChannels?.length) (returned true for an array with length of 0)

Channel deletion warning images:

Note:

Changing the selectHasYoutubeChannels to return false, when account doesn't have any connected YouTube channels, changes how the empty channel page looks.

Images:

OLD:

NEW:

@tzarebczan
Copy link
Contributor

Awesome, thank you!

@tzarebczan tzarebczan merged commit 61c1d7c into OdyseeTeam:master Feb 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants