Fix the new list editing isuses #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
List editing issues created by #3061
-Allow editing private/edited lists, no matter if items were resolved or not (urls are already known, so items won't disappear, I think)
-Public list with 0 items can get considered as successfully resolved now (This caused issues if all list items were deleted.)
-Minor changes to checking for resolving items. Also noticed some items getting stuck in
resolvingUris, shouldn't matter for this due to private/edited lists are now allowed being edited always. (I wasn't able to figure out why those were stuck, or how to clear without clearing anything unwanted)