Fix selectIsCollectionPrivateForId
#3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't got any lint issues locally, seems to be related to previous PR |
|
@toshokanneko worth fixing that lint issue or I should just push it through? |
|
I fixed it in the master branch. |
keikari
force-pushed
the
fix-privatelist-publish-edit
branch
from
11deb28 to
a3aef43
Compare
|
Updated, I think. I don't have permission to merge, so will need help with that part too : D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private list with unpublished edits wasn't actually considered private. So if editing in publishing form, would cause submit to try to do
collectionUpdate.Fix:
Copied the related stuff from
selectHasPrivateCollectionForIdtoselectIsCollectionPrivateForId, just left out the checks for private versions of published lists.Didn't test much, but don't really see how this could cause any surprises. (Unpublished collections only has the actually private lists)