Fix attempt - Sometimes wild-west-like results appear in hometab playlists #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keikari
changed the title
keikari
force-pushed
the
fix-hometab-list-bug
branch
from
655dccb to
cda9380
Compare
keikari
commented
Apr 22, 2024
| ) | ||
| )} | ||
| {section.type !== 'channels' | ||
| ? (collectionUrls || claimSearchResults || collectionClaimIds) && ( |
There was a problem hiding this comment.
This check was the only change
|
Thanks for fixing, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://secure.helpscout.net/conversation/2570541219/242582?folderId=4588968
User reported about sometimes having some random items showing in their home tab playlists.
There was a generic claim search happening when reloading the channel hometab page(screenshot of the params), and results from that got shown sometimes on some lists before the real items got loaded.
Issue can be seen if reloading this page:
https://odysee.com/@Flaviano_Pasinetti:2
Un-wanted generic claim search is consistent. Seeing the effects on UI isn't consistent.
I don't understand why the issue exactly happens, but this seems to fix it. And doesn't seem to break other hometab sections