Add timeout tunnel #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersmitten
reviewed
Jan 29, 2020
| @@ -48,6 +48,8 @@ haproxy_defaults_timeout: | |||
| timeout: 50000 | |||
| - type: server | |||
| timeout: 50000 | |||
| - type: tunnel | |||
| timeout: "1h" | |||
There was a problem hiding this comment.
Is this the default form the documentation?
There was a problem hiding this comment.
Not sure if it's the default as it's not specified in the documentation. But it's the one given in the example: http://cbonte.github.io/haproxy-dconv/2.2/configuration.html#4-timeout%20tunnel
There was a problem hiding this comment.
I'm not convinced that this should be added to haproxy_defaults_timeout (by default, unless it's now in the default haproxy config file). Off course you are free to override it yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.