Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample Code Optimization - Ashlesha #1525

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Sample Code Optimization - Ashlesha #1525

merged 12 commits into from
Jan 30, 2025

Conversation

Harikrishnan-MSFT
Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT commented Jan 9, 2025 •
edited
Loading

Sample List -

@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Sample Code Optimization Sample Code Optimization - Ashlesha Jan 9, 2025
@Pawank-MSFT Pawank-MSFT requested a review from Copilot January 10, 2025 10:34
Copilot
Copilot AI reviewed Jan 10, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • samples/app-hello-world/nodejs/env/.env.local: Language not supported
  • samples/app-hello-world/nodejs/src/views/configure.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/first.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/hello.html: Language not supported
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Configure.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/First.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Index.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Second.cshtml: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/static/scripts/teamsapp.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/build.js: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Bots/MessageExtension.cs: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/app.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/tabs.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/message-extension.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/bot.js: Evaluated as low risk
Comments suppressed due to low confidence (1)

samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Program.cs:6

  • The XML documentation is missing the tags. It should be corrected for consistency and clarity.
/// The entry point for the application, responsible for configuring and starting the web host.
@Pawank-MSFT Pawank-MSFT added the DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. label Jan 10, 2025
Pawank-MSFT
Pawank-MSFT reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct this.

...les/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/AdapterWithErrorHandler.cs Outdated Show resolved Hide resolved
...les/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/AdapterWithErrorHandler.cs Show resolved Hide resolved
...s/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Controllers/BotController.cs Show resolved Hide resolved
samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Program.cs Show resolved Hide resolved
samples/app-hello-world/nodejs/src/bot.js Outdated Show resolved Hide resolved
samples/app-hello-world/nodejs/src/views/first.html Show resolved Hide resolved
samples/app-hello-world/nodejs/src/views/first.html
<link rel="stylesheet" type="text/css" href="/styles/custom.css">
</link>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing tag should not be removed

samples/app-hello-world/nodejs/src/views/second.html Show resolved Hide resolved
samples/app-hello-world/nodejs/src/views/second.html Show resolved Hide resolved
samples/app-hello-world/python/bots/bot.py Outdated Show resolved Hide resolved
Copilot
Copilot AI reviewed Jan 16, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 59 out of 74 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • samples/app-hello-world/nodejs/env/.env.local: Language not supported
  • samples/app-hello-world/nodejs/src/views/configure.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/first.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/hello.html: Language not supported
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Configure.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Second.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Index.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/First.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Program.cs: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/AdapterWithErrorHandler.cs: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Controllers/HomeController.cs: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Controllers/BotController.cs: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Bots/MessageExtension.cs: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/message-extension.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/static/scripts/teamsapp.js: Evaluated as low risk
Comments suppressed due to low confidence (3)

samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Startup.cs:43

  • [nitpick] Ensure consistent comment formatting by adding a period at the end of the comment.
services.AddControllers();  // Adds controllers to the service collection

samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Startup.cs:44

  • [nitpick] Ensure consistent comment formatting by adding a period at the end of the comment.
services.AddMvc(); // Adds MVC services for handling views and routes

samples/app-hello-world/nodejs/src/bot.js:22

  • [nitpick] The error message is too generic. Consider updating it to be more user-friendly, such as 'An unexpected error occurred. Please try again later.'
const errorMsg = error.message || 'Oops. Something went wrong!';
Copilot
Copilot AI reviewed Jan 16, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 106 out of 121 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • samples/app-hello-world/nodejs/env/.env.local: Language not supported
  • samples/app-hello-world/nodejs/src/views/configure.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/first.html: Language not supported
  • samples/app-hello-world/nodejs/src/views/hello.html: Language not supported
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Second.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Configure.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/First.cshtml: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Views/Home/Index.cshtml: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/static/scripts/teamsapp.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/build.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/tabs.js: Evaluated as low risk
  • samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Bots/MessageExtension.cs: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/app.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/bot.js: Evaluated as low risk
  • samples/app-hello-world/nodejs/src/message-extension.js: Evaluated as low risk

samples/app-hello-world/csharp/Microsoft.Teams.Samples.HelloWorld.Web/Program.cs Outdated
// Generated with Bot Builder V4 SDK Template for Visual Studio EchoBot v4.6.2
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Hosting;
// Generated with Bot Builder V4 SDK Template for Visual Studio EchoBot v4.6.2using Microsoft.AspNetCore.Hosting;
Copy link
Preview

Copilot AI Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the comment. It should be split into two lines: // Generated with Bot Builder V4 SDK Template for Visual Studio EchoBot v4.6.2 and using Microsoft.AspNetCore.Hosting;.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@Jegadeesh-MSFT
updating samples
768a0db 
1.Bot-initiate-thread-in-channel
2.Bot-file-upload
3.bot-daily-task-remainder
4.bot-people-picker-adaptive-card
Pawank-MSFT
Pawank-MSFT approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving!

@Pawank-MSFT
Copy link
Collaborator

Pawank-MSFT commented Jan 30, 2025 •
edited
Loading

Executed build pipeline:
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/13049504100
image

@Pawank-MSFT Pawank-MSFT merged commit fcf8121 into main Jan 30, 2025
549 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Pawank-MSFT Pawank-MSFT Pawank-MSFT approved these changes

@Mohammed-MSFT Mohammed-MSFT Mohammed-MSFT approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harikrishnan-MSFT @Pawank-MSFT @Mohammed-MSFT @Jegadeesh-MSFT