Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the teamsjs instance identifier and timestamp to every log line #2524

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

AE-MS
Copy link
Contributor

@AE-MS AE-MS commented Sep 23, 2024

Description

Added the teamsjs instance identifier and timestamp to every log line. This will help us debug issues where multiple teamsjs instances are being used (which is an unsupported scenario).

Validation

Validation performed:

Ensured everything looked right in the logs:
image
...even in the multi-instance scenario:
image

Change file added:

Yes

@AE-MS AE-MS marked this pull request as ready for review September 23, 2024 23:47
@AE-MS AE-MS requested a review from a team as a code owner September 23, 2024 23:47
@AE-MS AE-MS enabled auto-merge (squash) September 24, 2024 16:22
erinha
erinha previously approved these changes Sep 24, 2024
Copy link
Contributor

@erinha erinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions for potential added clarity and asked about perf. Overall, I love it!

@AE-MS AE-MS dismissed stale reviews from erinha and TrevorJoelHarris via 31091e5 September 24, 2024 18:11
Copy link
Contributor

@erinha erinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AE-MS AE-MS enabled auto-merge (squash) September 24, 2024 18:16
@AE-MS AE-MS merged commit 0f935e3 into main Sep 24, 2024
28 checks passed
@AE-MS AE-MS deleted the AE_MS/tjs_instance_log branch September 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants