Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the changes of moving common data models to interface file for externalAppCardAction(ForCEA) files #2535

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

MengyiGong
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

Revert the changes of moving common data models to interface file for externalAppCardAction(ForCEA) APIs to avoid the breaking changes.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

@MengyiGong MengyiGong requested a review from a team as a code owner October 1, 2024 19:12
@AE-MS
Copy link
Contributor

AE-MS commented Oct 1, 2024

If you are reverting the change that was meant to avoid breaking changes, does that mean that we're now intentionally making a breaking change? Why did we want to avoid it before but now we are okay with it?

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@MengyiGong
Copy link
Contributor Author

MengyiGong commented Oct 1, 2024

If you are reverting the change that was meant to avoid breaking changes, does that mean that we're now intentionally making a breaking change? Why did we want to avoid it before but now we are okay with it?

From the changes in the last PR, we did not realize we are making a "breaking change" (all the data models and functions are marked with @beta, so it is not breaking). It was not intentional change.

Confirmed with @lakhveerk and @erinha please correct me if I'm wrong:
We believe MChat have not consumed the beta version from last week. We are fixing it before they consume our new version.

lakhveerk
lakhveerk previously approved these changes Oct 2, 2024
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MengyiGong MengyiGong merged commit 078934e into main Oct 2, 2024
28 checks passed
@MengyiGong MengyiGong deleted the maggieg/revert_common_data_model branch October 2, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants