-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the changes of moving common data models to interface file for externalAppCardAction(ForCEA) files #2535
Conversation
…avoid breaking change
If you are reverting the change that was meant to avoid breaking changes, does that mean that we're now intentionally making a breaking change? Why did we want to avoid it before but now we are okay with it? |
change/@microsoft-teams-js-4fe5ca49-b46c-4a6b-b580-bd6035df67e6.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
From the changes in the last PR, we did not realize we are making a "breaking change" (all the data models and functions are marked with Confirmed with @lakhveerk and @erinha please correct me if I'm wrong: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about how to contribute to this repo, visit this page.
Description