fix: update error message when symlink exist (#11307)

OfficeDev · Apr 8, 2024 · 87f45d7 · 87f45d7
1 parent 26ca994
commit 87f45d7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/fx-core/resource/package.nls.json b/packages/fx-core/resource/package.nls.json
@@ -590,7 +590,7 @@
   "depChecker.learnMoreButtonText": "Learn more",
   "depChecker.needInstallNpm": "You must have NPM installed to debug your local functions.",
   "depChecker.failToValidateFuncCoreTool": "Unable to validate Azure Functions Core Tools after installation.",
-  "depChecker.symlinkDirAlreadyExist": "The destination of the symlink already exists",
+  "depChecker.symlinkDirAlreadyExist": "The destination of the symlink (%s) already exists, please remove it and try again.",
   "depChecker.portableFuncNodeNotMatched": "Your Node.js (@NodeVersion) is incompatible with Teams Toolkit Azure Functions Core Tools (@FuncVersion).",
   "depChecker.invalidFuncVersion": "The format of version %s is invalid.",
   "depChecker.noSentinelFile": "Azure Functions Core Tools installation is incomplete.",

diff --git a/packages/fx-core/src/common/deps-checker/constant/message.ts b/packages/fx-core/src/common/deps-checker/constant/message.ts
@@ -16,7 +16,8 @@ export const Messages = {
     getLocalizedString("depChecker.portableFuncNodeNotMatched")
       .replace("@NodeVersion", nodeVersion)
       .replace("@FuncVersion", funcVersion),
-  symlinkDirAlreadyExist: () => getLocalizedString("depChecker.symlinkDirAlreadyExist"),
+  symlinkDirAlreadyExist: (linkFilePath: string) =>
+    getLocalizedString("depChecker.symlinkDirAlreadyExist", linkFilePath),
   invalidFuncVersion: (version: string) =>
     getLocalizedString("depChecker.invalidFuncVersion", version),
   noSentinelFile: () => getLocalizedString("depChecker.noSentinelFile"),

diff --git a/packages/fx-core/src/common/deps-checker/util/fileHelper.ts b/packages/fx-core/src/common/deps-checker/util/fileHelper.ts
@@ -27,7 +27,7 @@ export async function createSymlink(target: string, linkFilePath: string): Promi
   await unlinkSymlink(linkFilePath);
   // check if destination already exists
   if (await fs.pathExists(linkFilePath)) {
-    throw new DepsCheckerError(Messages.symlinkDirAlreadyExist(), v3DefaultHelpLink);
+    throw new DepsCheckerError(Messages.symlinkDirAlreadyExist(linkFilePath), v3DefaultHelpLink);
   }
 
   return await fs.ensureSymlink(