Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: prerelease Sep 04 #12379

Merged
merged 39 commits into from
Sep 12, 2024

Merge pull request #12370 from OfficeDev/hui/feature-flag-aad

fddd364
Select commit
Loading
Failed to load commit list.
Merged

build: prerelease Sep 04 #12379

Merge pull request #12370 from OfficeDev/hui/feature-flag-aad
fddd364
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2024 in 0s

94.71% (+4.61%) compared to a78e21f

View this Pull Request on Codecov

94.71% (+4.61%) compared to a78e21f

Details

Codecov Report

Attention: Patch coverage is 98.39506% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.71%. Comparing base (a78e21f) to head (fddd364).
Report is 68 commits behind head on dev.

Files with missing lines Patch % Lines
...core/src/component/driver/teamsApp/syncManifest.ts 96.37% 5 Missing ⚠️
...ackages/fx-core/src/common/secretmasker/feature.ts 94.44% 2 Missing ⚠️
packages/fx-core/src/core/FxCore.ts 97.53% 2 Missing ⚠️
.../src/component/driver/teamsApp/createAppPackage.ts 95.65% 1 Missing ⚠️
.../fx-core/src/component/generator/apiSpec/helper.ts 98.07% 1 Missing ⚠️
...src/component/generator/copilotExtension/helper.ts 98.52% 1 Missing ⚠️
packages/fx-core/src/question/constants.ts 96.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12379      +/-   ##
==========================================
+ Coverage   90.10%   94.71%   +4.61%     
==========================================
  Files         580      582       +2     
  Lines       36782    35172    -1610     
  Branches     7471     6912     -559     
==========================================
+ Hits        33141    33314     +173     
+ Misses       1613     1582      -31     
+ Partials     2028      276    -1752
Files with missing lines Coverage Δ
packages/api/src/types.ts 0.00% <ø> (ø)
packages/cli/src/commands/common.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/add.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/create.ts 100.00% <ø> (+2.77%) ⬆️
...ckages/cli/src/commands/models/teamsapp/package.ts 100.00% <ø> (ø)
...ckages/cli/src/commands/models/teamsapp/publish.ts 100.00% <ø> (ø)
...ackages/cli/src/commands/models/teamsapp/update.ts 100.00% <ø> (ø)
...kages/cli/src/commands/models/teamsapp/validate.ts 100.00% <ø> (+4.76%) ⬆️
packages/cli/src/userInteraction.ts 87.14% <ø> (+4.58%) ⬆️
packages/fx-core/src/common/constants.ts 95.34% <100.00%> (+2.32%) ⬆️
... and 66 more

... and 253 files with indirect coverage changes

View more details on Codecov