-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
258 mongo entity 리팩토링 #259
Open
eugene225
wants to merge
34
commits into
develop
Choose a base branch
from
258-mongo-entity-리팩토링
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "258-mongo-entity-\uB9AC\uD329\uD1A0\uB9C1"
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧙 PR 타입
🤨 Motivation
Resolved #258
🔑 Key Changes
chatMessageMongo
document에 chatRoomId 필드 추가updated_at
필드로 변경_id
필드로 변경chat_participants
엔터티에 추가되었던lastReadMsgId
정보를 MongoDB의chat_activity
collection으로 이전chat_activity
컬렉션 조회 : 채팅방별lastReadMsgId
확인chat_messages
컬렉션 조회 : 채팅방별unReadMsgCnt
집계🙏 To Reviewers
너무 길어졌어요....죄송합니다.............
저번에 고민했던 chat_participant 테이블과 participant 테이블 두가지의 필요성에 대한 부분을 lastReadMsgId 필드를 아예 MongoDB로 이전하면서 조금 풀렸습니다. chat_participant 엔터티를 삭제하는 리팩토링을 따로 이슈를 파서 진행하면 좋을 것 같습니다..! 코드 보시고 같은
의견이신지 인수님 의견도 궁금합니당
코드 확인해보시고 어색한 부분이나 제가 놓친부분 있으면 코멘트 달아주세요 저도 너무 많은걸 고쳐서 이제 어지럽습니다..🫠