Add error message to CALL/INFO #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
|
Merged, but I think it should be improved: Oldes/Rebol-issues#2635 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
CALL/INFOwould give no indication of what the error was or even if there was one beyond setting the PID to zero. Now it includes the error message when encountering an error.I pulled the code from
f-stubs.c'sMake_OS_Error()function. I would prefer to convert theREBVALreturned byMake_OS_Error()into aREBSERinstead but I wasn't sure how to do so with the macro system.Consider this a proof of concept if there is a better way.