generated from grodin/kotlin-android-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update detekt to v1.23.4 #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
force-pushed
the
renovate/detekt
branch
2 times, most recently
from
November 4, 2023 12:24
e322478
to
5f42787
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
2 times, most recently
from
November 16, 2023 10:08
76244db
to
e55646e
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
3 times, most recently
from
November 17, 2023 12:35
d982548
to
7aa3927
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
3 times, most recently
from
November 26, 2023 13:15
e4d781b
to
f69642e
Compare
renovate
bot
changed the title
chore(deps): update detekt to v1.23.3
chore(deps): update detekt to v1.23.4
Nov 26, 2023
grodin
force-pushed
the
renovate/detekt
branch
from
November 29, 2023 11:54
f69642e
to
a15ef58
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
8 times, most recently
from
December 7, 2023 09:20
2f2ece2
to
27fb078
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
2 times, most recently
from
December 13, 2023 08:06
32a53c0
to
f8569d5
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
3 times, most recently
from
December 19, 2023 12:18
29f070a
to
f5855c0
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
from
December 22, 2023 08:33
f5855c0
to
1e86de7
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
4 times, most recently
from
January 11, 2024 14:44
609c8fd
to
b0781b1
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
from
January 17, 2024 23:40
b0781b1
to
5f0ec9d
Compare
renovate
bot
force-pushed
the
renovate/detekt
branch
from
January 19, 2024 10:14
5f0ec9d
to
548a8da
Compare
In the change to detekt v1.24.3, several detekt APIs were deprecated, but this was not done correctly, and some APIs were actually removed! Further, if the detekt config file includes formatting settings, detekt-cli requires the detekt formatting plugin to be on the classpath (another breaking change). Formatting is done with ktfmt so we just remove the formatting section from the detekt config.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Closes #149 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.18.1
->1.23.4
1.18.1
->1.23.4
1.18.1
->1.23.4
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
detekt/detekt (io.gitlab.arturbosch.detekt)
v1.23.4
1.23.4 - 2023-11-26
This is a point release for Detekt
1.23.0
, where we added support for Kotlin1.9.21
and fixed several bugs thatgot reported by the community.
Notable Changes
Changelog
Dependency Updates
Contributors
We would like to thank the following contributors that made this release possible: @3flex, @BraisGabin, @Gosunet, @atulgpt, @t-kameyama
v1.23.3
1.23.3 - 2023-10-31
This is a point release for Detekt
1.23.0
, where we added support for Kotlin1.9.10
and fixed several bugs thatgot reported by the community.
NOTE: This is a republishing of 1.23.2 which was accidentally published against Kotlin 1.9.0 instead of 1.9.10
Changelog
IgnoredReturnValue
with scope functions - #6446Dependency Updates
Contributors
We would like to thank the following contributors that made this release possible: @3flex, @arturbosch, @atulgpt, @kkocel, @marschwar, @pablobaxter, @t-kameyama
v1.23.2
1.23.2 - 2023-10-29
NOTE: Please use version 1.23.3 instead - Version 1.23.2 was accidentally built against Kotlin 1.9.0 instead of 1.9.10
https://github.com/detekt/detekt/releases/tag/v1.23.3
This is a point release for Detekt
1.23.0
, where we added support for Kotlin1.9.10
and fixed several bugs thatgot reported by the community.
Changelog
IgnoredReturnValue
with scope functions - #6446Dependency Updates
Contributors
We would like to thank the following contributors that made this release possible: @3flex, @arturbosch, @atulgpt, @kkocel, @marschwar, @pablobaxter, @t-kameyama
v1.23.1
1.23.1 - 2023-07-30
This is a point release for Detekt
1.23.0
, where we added support for Kotlin1.9.0
and fixed several bugs thatgot reported by the community.
Notable Changes
Changelog
..<
andrangeTo
in theForEachOnRange
rule - #6197UseDataClass
if class contains non-property parameters - #6173replaceIndent
andprependIndent
- #6154Dependency Updates
Contributors
We would like to thank the following contributors that made this release possible: @3flex, @Goooler, @Hexcles, @PoisonedYouth, @TWiStErRob, @VirtualParticle, @atulgpt, @cortinico, @dzirbel, @eygraber, @marschwar, @rmarquis, @segunfamisa, @severn-everett, @t-kameyama
See all commit history here
v1.23.0
We're so proud to announce the next upcoming stable release of detekt: 1.23.0 🚀
This release is coming with 25 new rules and much more.
We moved the detekt-compiler-plugin to the main repo, and you can now use it in your builds following the official documentation.
This release also marks the beginning of development of 2.x from the main branch! You can follow the progress here
We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).
Notable Changes
detekt-compiler-plugin
. The Detekt Compiler plugin is still experimental, but we're moving it closer to Detekt to make it easier to integrate. From now on the compiler plugin will follow the same versioning schema as Detekt. We invite you to try it and provide feedback till we stabilize it. You can read more about it in the official documentation page - #5492BracesOnIfStatements
- #5700BracesOnWhenStatements
- #5838CastNullableToNonNullableType
- #5653DoubleNegativeLambda
- #5937ForbiddenAnnotation
- #5515PropertyUsedBeforeDeclaration
- #6062StringShouldBeRawString
- #5705SuspendFunSwallowedCancellation
- #5666UnusedParameter
- #5722UnusedPrivateProperty
- #5722UseLet
- #6091UnnecessaryBracesAroundTrailingLambda
- #6029detekt-formatting
ruleset:ClassName
- #6037EnumWrapping
- #6028FunctionName
- #6037IfElseBracing
- #6028IfElseWrapping
- #6028MultilineExpressionWrapping
- #6028NoBlankLineInList
- #6028NoConsecutiveComments
- #6028NoEmptyFirstLineInClassBody
- #6028NoSingleLineBlockCommentRule
- #6104ParameterWrapping
- #6028PropertyName
- #6037PropertyWrapping
- #6028StringTemplateIndent
- #6028TryCatchFinallySpacing
- #6028UnnecessaryAbstractClass
now only runs with type resolution - #5829UnusedPrivateMember
has been refactored with some of its logic moved toUnusedParameter
andUnusedPrivateProperty
- #5722ignoreOverridden
config fromBooleanPropertyNaming
,ConstructorParameterNaming
,FunctionNaming
,VariableNaming
andFunctionParameterNaming
as not useful for those rules - #5718ignoredSubjectTypes
to ruleElseCaseInsteadOfExhaustiveWhen
to specify types that should be ignored by the rule (#5623) - #5634allowOperators
to ruleDataClassContainsFunctions
- #5658MandatoryBracesIfStatements
has been removed in favor ofBracesOnIfStatements
- #5700ignoreWhenContainingVariableDeclaration
toUseIfInsteadOfWhen
to ignore captured variables - #5681detekt-formatting
ruleset now accepts anindentSize
parameter (see the full list here).detekt-formatting
ruleset are now turned on by default (see the full list here).includes
/excludes
logic on the config file as they were overriding each other - #5782detekt-test-utils
. The recommended testing framework is JUnit - #5785v6.8.3
- #5616v8.1
, AGP8.0.1
, Kotlin1.8.21
and KtLint0.49.1
(see #5893 #5723 #5877 #6028 #6043 #5995 #5996)Changelog
comments
with a list of regexes toForbiddenComment
- #5981requireRootInDeclaration
check inInvalidPackageDeclaration
- #6045detekt-versions.properties
instead ofversions.properties
- #6006allowOmitUnit
to ruleLibraryCodeMustSpecifyReturnType
- #58618c8d71d
- #5966Unit
for ImplicitUnitReturnType rule - #5857TestConfig
usages - #5801name
that return name after backticks - #5719CanBeNonNullable
rule - #5714MaxLineLength
- #5583Dependency Updates
Housekeeping & Refactorings
eaaf4be
- #6102dependenciesAsNames
- #6059ClassNaming
andFunctionNaming
- #6019detekt-generator
- #5854generateWebsite
- #5849@Suppress("ReturnCount")
- #5841times
method, use stdlib'srepeat
instead. - #5774Contributors
We would like to thank the following contributors that made this release possible: @3flex, @BeBAKE, @BraisGabin, @Goooler, @SaumyaBhushan, @TWiStErRob, @VitalyVPinchuk, @adef145, @asomov, @atulgpt, @chao2zhang, @cketti, @cortinico, @drawers, @dzirbel, @igorwojda, @lexa-diky, @luanpotter, @marschwar, @mjovanc, @mmorozkov, @ncteisen, @osipxd, @ov7a, @schalkms, @t-kameyama, @tresni
See all issues at: 1.23.0
v1.22.0
We're extremely excited to announce the next upcoming stable release of Detekt: 1.22.0 🚀
This release is coming with 16 new rules, 2 new rulesets and several new functionalities & APIs.
We've also introduced the Detekt Marketplace, a place for users to share their 3rd party rules and extensions.
We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).
Notable Changes
AlsoCouldBeApply
- #5333MultilineRawStringIndentation
- #5058TrimMultilineRawString
- #5051UnnecessaryNotNullCheck
- #5218UnnecessaryPartOfBinaryExpression
- #5203UseSumOfInsteadOfFlatMapSize
- #5405FunctionReturnTypeSpacing
from KtLint - #5256FunctionSignature
from KtLint - #5256FunctionStartOfBodySpacing
from KtLint - #5256NullableTypeSpacing
from KtLint - #5256ParameterListSpacing
from KtLint - #5256SpacingBetweenFunctionNameAndOpeningParenthesis
from KtLint - #5256TrailingCommaOnCallSite
from KtLint - #5312TrailingCommaOnDeclarationSite
from KtLint - #5312TypeParameterListSpacing
from KtLint - #5256detekt-rules-ruleauthors
containing rules for Rule Authors to enforce best practices on Detekt rules such as the newViolatesTypeResolutionRequirements
- #5129 #5182detekt-rules-libraries
containing rules mostly useful for Library Authors - We moved the following rules insideForbiddenPublicDataClass
,LibraryCodeMustSpecifyReturnType
,LibraryEntitiesShouldNotBePublic
this new ruleset - See Migration below on how to migrate #5360--jdk-home
CLI parameter - #5269@RequiresTypeResolution
when without Type Resolution - #5176checkExhaustiveness: true
in your config file. This is disabled by default. - #5089--fail-fast
CLI flag (andfailFast
Gradle property) has been removed. It was deprecated since 1.16.x - #5290DuplicateCaseInWhenExpression
,MissingWhenCase
,RedundantElseInWhen
as the Kotlin Compiler is already reporting errors for those scenarios - #5309--print-ast
CLI flag as PsiViewer provides the same features - #5418ArrayPrimitive
is now working only with Type Resolution - #5175WildcardImport
is now running also on tests by default - #5121ForbiddenImport
allows now to specify a reason for every forbidden import - #4909IgnoredReturnValue
: optionrestrictToAnnotatedMethods
is now deprecated in favor ofrestrictToConfig
- #4922v7.5.1
, AGP7.3.1
, Kotlin1.7.21
and KtLint0.47.1
(see #5363 #5189 #5411 #5312 #5519)v6.7.1
- #4964Migration
We deprecated a number of rules in this release.
You should update your config file as follows:
If you wish to use the
libraries
ruleset we introduced you should add the following to your config file:and add the following to you
build.gradle
file:detektPlugins("io.gitlab.arturbosch.detekt:detekt-rules-libraries:$version")
If you're using our KtLint wrapper (i.e.
detekt-formatting
) you should also update your config file as follows:Changelog
UnnecessaryPartOfBinaryExpression
- #5514TrimMultilineRawString
false-positive on annotation parameters - #5476SafeCast
with no braces - #547955e685c
- #5472TrailingComma
as it's now split in two rules - #5423it
-started expressions - #5376FunctionOnlyReturningConstant>excludedFunctions
- #5120KotlinEnvironmentResolver
- #5275NestedScopeFunctions
- #5274UnnecessaryAbstractClass
issue description to be less verbose - #5224Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.