Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-docker-image: remove ubuntu user if it exists #49

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

adamseres
Copy link
Collaborator

Noble has a predefined ubuntu user with an 1000 uid. This prevents the creation of another user with 1000 uid so we need to delete it if it exists.

Noble is also added to the test distributions.

Copy link
Collaborator

@wferi wferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling Ubuntu noble should happen in a dedicated commit, please do not hide it in an unrelated one.
That userdel command leaves behind the /home/ubuntu directory owned by an unnamed user/group. This must be avoided, please use the -r option.

@adamseres adamseres force-pushed the master branch 2 times, most recently from 1732012 to 8e32547 Compare October 17, 2024 09:19
Copy link
Collaborator

@wferi wferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider fixing the grammar in

The user creation and user change test during selftest are work the same.

Simply dropping that line would also work fine for me.

Adam Seres added 3 commits October 22, 2024 12:38
The 1000 uid is already used by the predefined ubuntu user on noble.
Noble has a predefined ubuntu user with 1000 uid. This prevents the
creation of another user with 1000 uid so we need to delete it if
it exists.
@adamseres adamseres merged commit 742f956 into OneIdentity:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants