-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix unique merchants not being proper "hint" types #2170
Conversation
Messes up Text Shuffle: Except Hints
There's almost certainly some better way to only apply these hints if the setting is enabled than what I'm doing for example. |
Upon review, this seems more like a new feature, since it marks items on these locations as already hinted, thus preventing gossip stones from also hinting them. To fix text shuffle, adding the message IDs to |
I like that it moves hint data out of Patches.py To make sure I'm understanding correctly, adding the hint logic means that hints won't be duplicated onto gossip stones? |
Can you elaborate on this? From looking at the changes to Messages.py, it seems like it should already be working correctly. |
I honestly remember nothing about this PR. I think Text Shuffle: Except Hint was at some point shuffling the hints (textboxes on the merchants saying what they are selling) for expensive merchants. Somebody who actually knows and cares about hints should probably be doing the fix for that if it even exists still. |
Unfortunate but understandable. Let me see if I can write a new PR based on this. |
Messes up Text Shuffle: Except Hint
I tried to modify the existing unique merchants "hint" text changes to use the existing hint framework. It's a little awkward being a bunch of settings under one
misc hints
setting so some extra work was needed.This has not been tested and I know almost nothing about how hints are actually supposed to work, so this'll need a thorough review as well.