Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix unique merchants not being proper "hint" types #2170

Closed

Conversation

flagrama
Copy link

@flagrama flagrama commented Feb 2, 2024

Messes up Text Shuffle: Except Hint

I tried to modify the existing unique merchants "hint" text changes to use the existing hint framework. It's a little awkward being a bunch of settings under one misc hints setting so some extra work was needed.

This has not been tested and I know almost nothing about how hints are actually supposed to work, so this'll need a thorough review as well.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Feb 3, 2024
@flagrama
Copy link
Author

flagrama commented Feb 3, 2024

There's almost certainly some better way to only apply these hints if the setting is enabled than what I'm doing for example.

@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Sep 15, 2024
@fenhl
Copy link
Collaborator

fenhl commented Sep 15, 2024

Upon review, this seems more like a new feature, since it marks items on these locations as already hinted, thus preventing gossip stones from also hinting them. To fix text shuffle, adding the message IDs to hint_ids would be enough.

@fenhl fenhl added Type: Enhancement New feature or request Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Sep 15, 2024
@cjohnson57
Copy link
Collaborator

I like that it moves hint data out of Patches.py

To make sure I'm understanding correctly, adding the hint logic means that hints won't be duplicated onto gossip stones?

@cjohnson57 cjohnson57 added Status: Waiting for Author Changes or response requested and removed Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Jan 13, 2025
@fenhl fenhl self-assigned this Jan 13, 2025
@fenhl
Copy link
Collaborator

fenhl commented Jan 14, 2025

Messes up Text Shuffle: Except Hint

Can you elaborate on this? From looking at the changes to Messages.py, it seems like it should already be working correctly.

@flagrama
Copy link
Author

I honestly remember nothing about this PR. I think Text Shuffle: Except Hint was at some point shuffling the hints (textboxes on the merchants saying what they are selling) for expensive merchants. Somebody who actually knows and cares about hints should probably be doing the fix for that if it even exists still.

@flagrama flagrama closed this Jan 14, 2025
@fenhl
Copy link
Collaborator

fenhl commented Jan 14, 2025

Unfortunate but understandable. Let me see if I can write a new PR based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM Status: Needs Testing Probably should be tested Status: Waiting for Author Changes or response requested Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants