Fix input viewer c-down and d-down. Remove unnecessary setup DLs #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Bug
fenhl
approved these changes
Aug 8, 2024
|
FWIW I had someone test on N64 and this works there too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input viewer c-down and d-down drawing functions call the wrong sprite_texture function. Also it is only necessary to call the setup dl once before drawing the inputs, not before each one. This PR addresses both of those.
Don't think this breaks anything currently in Dev, but it seems to have some incompatibilities with other features drawing to the overlay as shown in the attached screenshot, from my branch with the enemy map tracker enabled.