Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable time-of-day changes from blue warps #2287

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Aug 26, 2024

Fixes part of #2235. Also fixes a bug introduced with #2251 where the Bongo and Twinrova blue warps no longer set time of day.

Logic changes will be made in a separate PR after the upcoming release.

@fenhl fenhl added Type: Bug Something isn't working Component: Algorithm Search, Fill, Playthrough, etc Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested labels Aug 26, 2024
@fenhl fenhl marked this pull request as ready for review August 26, 2024 17:15
@fenhl fenhl added this to the next milestone Aug 26, 2024
@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Sep 2, 2024
Copy link

@tobiasgies tobiasgies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few minor nitpicks, but other than those, looks good to me.

ASM/c/blue_warp.c Show resolved Hide resolved
ASM/c/blue_warp.c Show resolved Hide resolved
ASM/c/blue_warp.c Outdated Show resolved Hide resolved
@fenhl fenhl removed Status: Needs Review Someone should be looking at it Component: Algorithm Search, Fill, Playthrough, etc labels Sep 8, 2024
@fenhl fenhl merged commit bb31ce7 into OoTRandomizer:Dev Sep 8, 2024
@fenhl fenhl deleted the blue-warp-tod branch September 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants