Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to return to title screen from the pause screen after the save prompt. #2339

Open
wants to merge 16 commits into
base: Dev
Choose a base branch
from

Conversation

owlisnotacat1
Copy link

this adds a configurable setting that can add the option to return to the title screen from the pause screen removing the need to press the reset button on the n64/wii or dying in game to reset the game.

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Dec 14, 2024
@r0bd0g
Copy link

r0bd0g commented Dec 14, 2024

I wanna know if you can use this to death hole wrong warp lol.

ASM/ootSymbols.ld Outdated Show resolved Hide resolved
ASM/c/kaleido_scope.c Outdated Show resolved Hide resolved
@owlisnotacat1 owlisnotacat1 marked this pull request as draft December 17, 2024 20:19
@owlisnotacat1
Copy link
Author

found that that the game fully crashes on wii if the player opens the pause screen

@owlisnotacat1
Copy link
Author

99.9999% sure the code is safe on wii now

@owlisnotacat1 owlisnotacat1 marked this pull request as ready for review December 19, 2024 06:27

#include "z64.h"

typedef signed char s8;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just add a header that mimics ultratypes.h for these base types

@@ -0,0 +1,73 @@
#pragma once
Copy link

@rrealmuto rrealmuto Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does our compiler support #pragma once?

Copy link

@flagrama flagrama Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a modern version of gcc so it should. Whether we should mix that with headers already using header guards is another question though.

@fenhl fenhl removed the Status: Under Consideration Developers are considering whether to accept or decline the feature described label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Setting specific to setting(s) Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants