-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HW]: Add Peak Ethernet Gateway DR support #455
base: main
Are you sure you want to change the base?
Conversation
b86466e
to
9ba6088
Compare
Cool! Is this some arbitrary protocol to send CAN messages over ethernet or is this in fact also the same as the HSI protocol? Also have a look at the functions naming, I think we mostly used "snake_case" in this repo |
I blame work.... I spend 8 hours a day typing
My understanding is that HSI is still undecided on if they are going to do DDS, SOME/IP, CAN tunneling, or some other thing... so there may not be an official schema yet. I imagine this would be close-ish to whatever they were thinking for CAN tunneling, but I have no idea haha. Seems likely it's some bespoke PEAK schema. |
Added a CAN plugin for the PEAK ethernet gateway.
9ba6088
to
c182b62
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently don't have the hardware for testing this myself, but if you found it working I'm all good with it
|
||
if (txOpened) | ||
{ | ||
rxBuffer.reset(new std::uint8_t[RX_BUFFER_SIZE_BYTES]()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahah mixing a little old C stuff with C++'s smart pointers, it does it's job I guess 😆
Describe your changes
Added a CAN hardware plugin for the PEAK Ethernet Gateway.
Works both on Linux and Windows so far!
This does require a small bit of config on the gateway itself. You need to create routes to your computer by IP address, and configure this setting:
The code is very much based on the C example from Peak, which was a little cursed admittedly/
How has this been tested?
Ran VT example from a PC on my local network, connecting to the gateway. Object pool loaded and behaved normally.