-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HW]: add VSCAN hardware interface #528
Open
GwnDaan
wants to merge
2
commits into
Open-Agriculture:main
Choose a base branch
from
GwnDaan:daan/vscan-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9de44d7
to
4bd33f5
Compare
ad3154
reviewed
Jan 10, 2025
hardware_integration/include/isobus/hardware_integration/vscan_plugin.hpp
Show resolved
Hide resolved
ad3154
reviewed
Jan 10, 2025
hardware_integration/include/isobus/hardware_integration/vscan_plugin.hpp
Show resolved
Hide resolved
ad3154
reviewed
Jan 10, 2025
ad3154
previously approved these changes
Jan 10, 2025
requires you to set the 'VSCAN_API_DIR' environment variable to the API SDK directory that contains the `.h`, `.lib` files. Furthermore, you need to put `vs_can_api.dll` in the same directory as the executable.
4bd33f5
to
c725cb9
Compare
c725cb9
to
5d8e219
Compare
ad3154
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds the VSCAN plugin (made by VSCOM) that works with several devices. It utilizes CANUSB/SLCAN interface over ASCII protocol.
It requires you to set the 'VSCAN_API_DIR' environment variable to the API SDK directory that contains the
.h
,.lib
files. Furthermore, you need to putvs_can_api.dll
in the same directory as the executable.How has this been tested?
Tested this with a WiCAN-USB adapter over the TCP connection. The adapter was set to AP mode and I directly connected to it over wifi. No problems uploading the seeder example, nor any issues going through the example. Note that the busload here is fairly low here, as only the VT, TC and seeder example were running in a controlled environment.
I don't recommend to use any adapter over a wireless connection in a production environment, but for testing or datalogging it can be useful.
std::shared_ptr<isobus::CANHardwarePlugin> canDriver = std::make_shared<isobus::VSCANPlugin>("192.168.80.1:23");