Add infrastructure to monitor the VT IOP loading progress #533
Conversation
martonmiklos
force-pushed
the
add_iop_load_indication
branch
2 times, most recently
from
a16446a to
4af0534
Compare
isobus/src/isobus_virtual_terminal_server_managed_working_set.cpp
Outdated
Show resolved
Hide resolved
isobus/include/isobus/isobus/isobus_virtual_terminal_working_set_base.hpp
Outdated
Show resolved
Hide resolved
isobus/src/isobus_virtual_terminal_server_managed_working_set.cpp
Outdated
Show resolved
Hide resolved
martonmiklos
force-pushed
the
add_iop_load_indication
branch
from
4af0534 to
0a6d623
Compare
There was a problem hiding this comment.
Very nice that you are working on this feature! It has a lot of added value in the VT
My 2 cents are as followed: I think you have everything to determine the things you are looking for. Adding extra class variables might be a bit overkill and perhaps a bit more risky. I've attached two suggestions for the functions how they can be without using the other added variables. I'm curious to hear what you think
isobus/src/isobus_virtual_terminal_server_managed_working_set.cpp
Outdated
Show resolved
Hide resolved
isobus/src/isobus_virtual_terminal_server_managed_working_set.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Daan Steenbergen <[email protected]>
Co-authored-by: Daan Steenbergen <[email protected]>
isobus/include/isobus/isobus/isobus_virtual_terminal_server_managed_working_set.hpp
Outdated
Show resolved
Hide resolved
isobus/include/isobus/isobus/isobus_virtual_terminal_server_managed_working_set.hpp
Outdated
Show resolved
Hide resolved
|
@martonmiklos I think you forgot to push your changes. My comments are still not resolved? |
Upps, you are right, fixed it now 🤭 |
|
Describe your changes
Added counters to being able to monitor the VT IOP download progress (which is usually done in several smaller chunks)
How has this been tested?
Built AgIsoVT with this version of stack and tested the IOP load indicators.