[HW]: Fix data race condition on started variable #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwnDaan
force-pushed
the
daan/fix-datarace-hardware-interface
branch
from
cf93199 to
80e16aa
Compare
|
ad3154
approved these changes
Feb 4, 2025
martonmiklos
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes the warnings in the TSAN output in this issue. It reports multiple data races.
By applying the changes in this PR, we make sure that all operations are atomic, or guarded by a mutex.
Fixes #544
Tested
This has been tested by running the
PGNRequestExampleTargetand making sure all TSAN warnings were gone.Furthermore, I have looked into the newly added mutex; it shouldn't be possible to reach a deadlock