Initial implementation to add extra info to an object in the project #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/object_info.rs:34
- [nitpick] The default name generated by the get_name method could be ambiguous or unclear. Consider including more descriptive information.
format!("{:?}: {:?}", u16::from(object.id()), object.object_type())
- fixes collapsing tree view when object changes - also passed around 'project design' more instead of it's variables
GwnDaan
force-pushed
the
daan/fix-collapses-on-object-id-change
branch
from
78c0d04 to
d7ac773
Compare
This was
linked to
issues
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bootstraps extra info we want to attach to an object inside the project with two variables:
unique_idandname.With the unique id, we fixed the bug where explorer tree view collapses when changing an object id