Implement cache detach/attach #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'stop_pipeline' filed may be reused during cache lifetime (e.g. when cache is detached and attached again - the pipeline would be freed and then re-allocated). Calling completion after detach before freeing the pipeline may lead to race condition. Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
From python3.11 the function accepts only NoneType, int, float, str, bytes, or bytearray Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Stop and cache detach were already sharing contexts implicitly, which allowed to reuse some functions in both pipelines. However, changing the context structs could lead to not obvious bugs. To prevent such errors both methods now share context structure explicitly Signed-off-by: Michal Mielewczyk <[email protected]>
Signed-off-by: Michal Mielewczyk <[email protected]>
Majority of management operations should be blocked for detached cache, although adding and removing cores should be possible. Signed-off-by: Michal Mielewczyk <[email protected]>
mmichal10
approved these changes
Jul 26, 2024
robertbaldyga
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.