Request improvements #811
Merged
Request improvements #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbaldyga
previously approved these changes
Sep 6, 2024
rafalste
previously approved these changes
Sep 9, 2024
Management path does not benefit much from mpools, as number of requests allocated is very small. It's less restrictive (mngt_queue does not have single-CPU affinity) thus avoiding mpool usage in management path allows to introduce additional restrictions on mpool, leading to I/O performance improvement. Signed-off-by: Robert Baldyga <[email protected]> Signed-off-by: Michal Mielewczyk <[email protected]>
Eliminate need to resolve cache based on the queue. This allows to share the queue between cache instances. The queue still holds pointer to a cache that owns the queue, but no management or io path relies on the queue -> cache mapping. Signed-off-by: Robert Baldyga <[email protected]> Signed-off-by: Michal Mielewczyk <[email protected]>
This avoids unnecessary map allocation and initialization of unused fields of request structure. It also allows to track thier number separately from the regular requests Signed-off-by: Robert Baldyga <[email protected]> Signed-off-by: Michal Mielewczyk <[email protected]>
mmichal10
dismissed stale reviews from rafalste and robertbaldyga
via
dc58eea
rafalste
approved these changes
Sep 9, 2024
robertbaldyga
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.