Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update stock plan to support multiple stock class ids #477

Conversation

lavens
Copy link
Contributor

@lavens lavens commented Mar 12, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds support for multiple stock classes to be associated with a stock plan.

Which issue(s) this PR fixes:
Fixes #461

cc @jarrettq

@jarrettq
Copy link

Our approach placed an emphasis on not introducing breaking changes, so the following items are worth pointing out:

  1. We've opted to mark fields like stock_class_id in the Stock Plan object as deprecated, with a goal to eventually sunset it in favor of a stock_class_ids list.
  2. stock_class_id is still an optional field in the Equity Compensation Issuance transaction, but we'd recommend eventually transitioning it to a required field to handle scenarios where a Stock Plan starts off with a single share class but adds support for other share classes in subsequent updates to it.

@lavens lavens force-pushed the issue-461-one-to-many-stock-plan-to-stock-classes branch 2 times, most recently from e27c3d5 to 450ef8b Compare March 26, 2024 16:31
@lavens lavens requested a review from pjohnmeyer March 26, 2024 16:58
- Stock plan supports stock_class_ids and marks stock_class_id as deprecated
- Remove oneOf validation in EquityCompensationIssuance for stock_plan_id and stock_class_id
@lavens lavens force-pushed the issue-461-one-to-many-stock-plan-to-stock-classes branch from 450ef8b to b2be678 Compare April 23, 2024 13:13
@pjohnmeyer pjohnmeyer merged commit 86b1229 into Open-Cap-Table-Coalition:main Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Need for One-to-Many Association between Stock class and Stock plan?
4 participants