Changing phone number validation pattern to allow extensions #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobyavis @pjohnmeyer - looking for review/approval. |
|
@jacobyavis @pjohnmeyer - please review/approve. Thanks! |
Sumukh
reviewed
May 21, 2024
schema/types/Phone.schema.json
Outdated
| "type": "string", | ||
| "pattern": "^\\+\\d{1,3}\\s\\d{2,3}\\s\\d{2,3}\\s\\d{4}$" | ||
| "pattern": "^\\+\\d{1,3}\\s\\d{2,3}\\s\\d{2,3}\\s\\d{4}(?:\\s(ext.|extension)\\s\\d+)?$" |
There was a problem hiding this comment.
From the TWG call, the lookahead seems unnecessary.
^\+\d{1,3}\s\d{2,3}\s\d{2,3}\s\d{4}(\s(ext.|extension)\s\d+)?$ seems to work fine.
pjohnmeyer
reviewed
May 21, 2024
schema/types/Phone.schema.json
Outdated
| "type": "string", | ||
| "pattern": "^\\+\\d{1,3}\\s\\d{2,3}\\s\\d{2,3}\\s\\d{4}$" | ||
| "pattern": "^\\+\\d{1,3}\\s\\d{2,3}\\s\\d{2,3}\\s\\d{4}(?:\\s(ext.|extension)\\s\\d+)?$" |
There was a problem hiding this comment.
TWG Notes: See if the lookahead ?: at the beginning here is actually necessary, it seems redundant with the trailing ?. Also I don't believe JSON-schema patterns support ?: see https://json-schema.org/understanding-json-schema/reference/regular_expressions
… number regex pattern
|
Pushed a change to remove the unnecessary lookahead. |
Sumukh
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Phone number validation pattern updated to allow extensions after the phone number.