Skip to content

Commit

Permalink
array_contains and array_find: Clarify that giving null as `val…
Browse files Browse the repository at this point in the history
…ue` always returns `false` or `null` respectively, also fixed the incorrect examples. #348
  • Loading branch information
m-mohr committed Mar 16, 2022
1 parent f4d5d03 commit e4df864
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Clarified that a `TargetDimensionExists` exception is thrown if the target dimension exists.
- `apply` and `array_apply`: Fixed broken references to the `absolute` process
- `apply_neighborhood`: Parameter `overlap` was optional but had no default value and no schena for the default value defined.
- `array_contains` and `array_find`: Clarify that giving `null` as `value` always returns `false` or `null` respectively, also fixed the incorrect examples. [#348](https://github.com/Open-EO/openeo-processes/issues/348)
- `array_interpolate_linear`: Return value was incorrectly specified as `number` or `null`. It must return an array instead. [#333](https://github.com/Open-EO/openeo-processes/issues/333)
- `rename_labels`: Clarified that the `LabelsNotEnumerated` exception is thrown if `source` is empty instead of if `target` is empty. [#321](https://github.com/Open-EO/openeo-processes/issues/321)
- `round`: Clarify that the rounding for ties applies not only for integers. [#326](https://github.com/Open-EO/openeo-processes/issues/326)
Expand Down
6 changes: 3 additions & 3 deletions array_contains.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
{
"name": "value",
"description": "Value to find in `data`.",
"description": "Value to find in `data`. If the value is `null`, this process returns always `false`.",
"schema": {
"description": "Any data type is allowed."
}
Expand Down Expand Up @@ -75,7 +75,7 @@
],
"value": null
},
"returns": true
"returns": false
},
{
"arguments": {
Expand Down Expand Up @@ -167,4 +167,4 @@
"result": true
}
}
}
}
6 changes: 3 additions & 3 deletions array_find.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
{
"name": "value",
"description": "Value to find in `data`.",
"description": "Value to find in `data`. If the value is `null`, this process returns always `null`.",
"schema": {
"description": "Any data type is allowed."
}
Expand Down Expand Up @@ -106,7 +106,7 @@
],
"value": null
},
"returns": 1
"returns": null
},
{
"arguments": {
Expand Down Expand Up @@ -168,4 +168,4 @@
"title": "Find no-data values in arrays"
}
]
}
}

0 comments on commit e4df864

Please sign in to comment.