Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_stac and remove job-id subtype #384 #413

Merged
merged 8 commits into from
Mar 31, 2023
Merged

load_stac and remove job-id subtype #384 #413

merged 8 commits into from
Mar 31, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Mar 8, 2023

To avoid ambiguities, I think we can remove the batch job id subtype. A batch job ID can also just be provided via the uri subtype. Either you provide the canonical (i.e. "public") link and then it's just like any external data. Or you can simply provide a URI such as https://example.com/api/v1.0/jobs/12345/results and then you can easily detect the job id from it. The clients can help with it by allowing Job objects as input for example.

@m-mohr m-mohr added the breaking label Mar 8, 2023
@m-mohr m-mohr added this to the 2.0.0 milestone Mar 8, 2023
@m-mohr m-mohr linked an issue Mar 8, 2023 that may be closed by this pull request
@m-mohr m-mohr changed the title Remove job-id subtype #384 load_stac and remove job-id subtype #384 Mar 8, 2023
This was linked to issues Mar 8, 2023
@m-mohr m-mohr linked an issue Mar 10, 2023 that may be closed by this pull request
Copy link
Contributor

@LukeWeidenwalker LukeWeidenwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! Subsuming the openeo-internal "result" concept into the generally-applicable "datacube-described-by-STAC" concept (which exists outside of openeo) makes total sense to me.

What prevents us from doing something similar for load_collection? At the end of the day each collection is also just a STAC collection, right? Is the "collection" concept in openeo anything other than "STAC collection openeo platform knows about and has an explicit name for"? The geometry parameter that load_collection has could just as well be added to load_stac.

(If my understanding of the collection abstraction is somehow inaccurate, I'd also love to hear in what way 😇)

@jdries
Copy link
Contributor

jdries commented Mar 13, 2023

@LukeWeidenwalker FYI, not each openEO collection is a STAC collection. In Terrascope backend for instance, the majority of collections is based on opensearch or even simply finding tif or netcdf files on disk by globbing.

@m-mohr
Copy link
Member Author

m-mohr commented Mar 14, 2023

Change id to url.

# Conflicts:
#	proposals/load_ml_model.json
@m-mohr
Copy link
Member Author

m-mohr commented Mar 14, 2023

Ready for review.

proposals/load_stac.json Outdated Show resolved Hide resolved
@m-mohr m-mohr self-assigned this Mar 29, 2023
@m-mohr m-mohr force-pushed the issue-384 branch 3 times, most recently from 3437c4d to 45b26fc Compare March 30, 2023 13:30
@m-mohr m-mohr requested a review from soxofaan March 30, 2023 13:35
m-mohr added 2 commits March 31, 2023 09:48
# Conflicts:
#	proposals/load_stac.json
@m-mohr m-mohr merged commit a1f5e73 into draft Mar 31, 2023
@m-mohr m-mohr deleted the issue-384 branch March 31, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants