-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_stac and remove job-id subtype #384 #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change! Subsuming the openeo-internal "result" concept into the generally-applicable "datacube-described-by-STAC" concept (which exists outside of openeo) makes total sense to me.
What prevents us from doing something similar for load_collection
? At the end of the day each collection is also just a STAC collection, right? Is the "collection" concept in openeo anything other than "STAC collection openeo platform knows about and has an explicit name for"? The geometry
parameter that load_collection
has could just as well be added to load_stac
.
(If my understanding of the collection abstraction is somehow inaccurate, I'd also love to hear in what way 😇)
@LukeWeidenwalker FYI, not each openEO collection is a STAC collection. In Terrascope backend for instance, the majority of collections is based on opensearch or even simply finding tif or netcdf files on disk by globbing. |
Change id to url. |
# Conflicts: # proposals/load_ml_model.json
Ready for review. |
3437c4d
to
45b26fc
Compare
# Conflicts: # CHANGELOG.md
# Conflicts: # proposals/load_stac.json
To avoid ambiguities, I think we can remove the batch job id subtype. A batch job ID can also just be provided via the uri subtype. Either you provide the canonical (i.e. "public") link and then it's just like any external data. Or you can simply provide a URI such as
https://example.com/api/v1.0/jobs/12345/results
and then you can easily detect the job id from it. The clients can help with it by allowing Job objects as input for example.