Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue527 load stac metadata #548

Merged
merged 13 commits into from
Mar 25, 2024
Merged

Issue527 load stac metadata #548

merged 13 commits into from
Mar 25, 2024

Conversation

VincentVerelst
Copy link
Collaborator

No description provided.

@VincentVerelst VincentVerelst requested a review from soxofaan March 12, 2024 16:11
@VincentVerelst VincentVerelst marked this pull request as ready for review March 12, 2024 16:11
soxofaan
soxofaan reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick notes

openeo/metadata.py Show resolved Hide resolved
openeo/metadata.py Outdated Show resolved Hide resolved
openeo/metadata.py Outdated Show resolved Hide resolved
openeo/metadata.py Outdated Show resolved Hide resolved
openeo/metadata.py Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/test_metadata.py Outdated Show resolved Hide resolved
@VincentVerelst
Copy link
Collaborator Author

@soxofaan , addressed all your initial comments.

@soxofaan soxofaan linked an issue Mar 25, 2024 that may be closed by this pull request
No metadata for datacube loaded with load_stac #527
Closed
@soxofaan soxofaan merged commit a963540 into Open-EO:master Mar 25, 2024
9 checks passed
soxofaan added a commit that referenced this pull request Mar 25, 2024
@soxofaan
Issue #113/#527/#548 add lower bound for pystac requirement and chang…
59655b8 
…elog entry
soxofaan added a commit that referenced this pull request Apr 4, 2024
@soxofaan
Issue #527/#548 minor metadata_from_stac fine-tuning
5cddb33
@clausmichele
Copy link
Member

@soxofaan @VincentVerelst I just seen this PR. The same functionality has been implemented by me here using the load_stac implementation:

openeo-python-client/openeo/local/connection.py

Line 116 in d64fc30

def load_stac(

but it's quite slow since it's building the datacube view of the queried Collection to get the metadata. It would be good to align and get the metadata in the same way, I will look into how to port it to the LocalConnection.

Just a comment: I don't like that the "bands" dimension has an hardcoded "bands" label. As experienced during the openeo-test-suite, this information should come from the datacube extension if it's available (cube.dimensions ...)
https://github.com/Open-EO/openeo-python-client/pull/548/files#diff-de2cebdb79abf5b65ca416029a8be7bed5e377d451383eef92cbec604d773122R583

@soxofaan
Copy link
Member

soxofaan commented May 6, 2024

@clausmichele indeed, this implementation is certainly open for further improvements and aligning. We just wanted to get some initial stuff in place to support some use cases

@soxofaan soxofaan mentioned this pull request Jun 3, 2024
Closed
@VincentVerelst VincentVerelst deleted the issue527-load-stac-metadata branch June 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No metadata for datacube loaded with load_stac
3 participants
@VincentVerelst @clausmichele @soxofaan