Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull job action away from track_statuses #711

Closed
wants to merge 8 commits into from

Conversation

HansVRP
Copy link
Contributor

@HansVRP HansVRP commented Jan 22, 2025

No description provided.

@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 22, 2025

@soxofaan does this design match with what we discussed yesterday?

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick notes

@HansVRP HansVRP requested a review from soxofaan January 23, 2025 10:18
@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 28, 2025

@soxofaan failing unit tests seem to be unrelated?

@soxofaan
Copy link
Member

yes failing tests are already failed on master (#715 ), so I would merge master in your branch

@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 28, 2025

@soxofaan there we go

@jdries
Copy link
Collaborator

jdries commented Jan 31, 2025

@soxofaan @HansVRP best to push this one forward, as it's quite urgent for lcfm. We'll also need to test it in a real world case to know if it actually solves the issue.

@jdries jdries linked an issue Jan 31, 2025 that may be closed by this pull request
@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 31, 2025

From my end, it's ready to merge. Uncertain if it will make a difference for LCFM. There we would need to pre-create a queue of created jobs

soxofaan pushed a commit that referenced this pull request Jan 31, 2025
@soxofaan
Copy link
Member

squashed and merged in 6dbf2f0

@soxofaan soxofaan closed this Jan 31, 2025
@soxofaan soxofaan deleted the issue663_performant_mbjm branch January 31, 2025 10:28
soxofaan added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job Manager: avoid gap between finishing job and starting new one
3 participants