Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feature/group permissions2.0 #277

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

WIP: Feature/group permissions2.0 #277

wants to merge 28 commits into from

Conversation

Enquier
Copy link
Contributor

@Enquier Enquier commented Apr 17, 2024 •
edited
Loading

Rebasing of groupPermissions adding the following in support of Local (mms-only) Groups:

  1. Authentication refactor to support clear User vs Auth workflows
  2. Group refactor adding API capabilities
  3. Group permission management (i.e. Admin Users who will be able to add/remove members from local (mms-only) groups).

@Enquier Enquier changed the title Feature/group permissions2.0 WIP: Feature/group permissions2.0 Apr 17, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2024
View reviewed changes
groups/src/main/java/org/openmbee/mms/groups/objects/GroupsResponse.java

public List<String> getGroups() {
return groups;
public List<GroupJson> getGroups() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getGroups exposes the internal representation stored in field groups. The value may be modified
after this call to getGroups
Loading
.
users/src/main/java/org/openmbee/mms/users/security/AbstractUsersDetailsService.java Fixed Show fixed Hide fixed
users/src/main/java/org/openmbee/mms/users/security/AbstractUsersDetailsService.java Fixed Show fixed Hide fixed
ldap/src/main/java/org/openmbee/mms/ldap/security/LdapUsersDetailsService.java Fixed Show fixed Hide fixed
ldap/src/main/java/org/openmbee/mms/ldap/security/LdapUsersDetailsService.java Fixed Show fixed Hide fixed
ldap/src/main/java/org/openmbee/mms/ldap/security/LdapUsersDetailsService.java Fixed Show fixed Hide fixed
localauth/src/main/java/org/openmbee/mms/localauth/security/LocalUsersDetailsService.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 3, 2024
View reviewed changes
ldap/src/main/java/org/openmbee/mms/ldap/security/LdapUsersDetailsService.java
private class UserAttributesMapper implements ContextMapper<UserJson> {


public UserJson mapFromContext(Object ctx) throws NamingException {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ContextMapper.mapFromContext
Loading
; it is advisable to add an Override annotation.
users/src/main/java/org/openmbee/mms/users/security/DefaultUsersDetailsService.java
return userPersistence.save(user);
}

public Collection<UserJson> getUsers() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
UsersDetailsService.getUsers
Loading
; it is advisable to add an Override annotation.
users/src/main/java/org/openmbee/mms/users/security/DefaultUsersDetailsService.java
this.userPersistence = userPersistence;
}

public UserJson saveUser(UserJson user) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
UsersDetailsService.saveUser
Loading
; it is advisable to add an Override annotation.
users/src/main/java/org/openmbee/mms/users/security/DefaultUsersDetailsService.java
saveUser(user);
}

public UserJson update(UserCreateRequest req, UserJson user) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
UsersDetailsService.update
Loading
; it is advisable to add an Override annotation.
ldap/src/main/java/org/openmbee/mms/ldap/security/LdapUsersDetailsService.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
groups/src/main/java/org/openmbee/mms/groups/controllers/LocalGroupsController.java
}
g.setName(group.getName());
g.setType(group.getType());
logger.info("Saving group: {}", g.getName());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
Loading
.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 21, 2024
View reviewed changes
groups/src/main/java/org/openmbee/mms/groups/controllers/LocalGroupsController.java
return response;
@PreAuthorize("isAuthenticated()")
public GroupsResponse getAllGroups(
Authentication auth) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'auth' is never used.
@HuiJun
Copy link
Collaborator

HuiJun commented May 29, 2024

Why is gradlew an empty file now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enquier @HuiJun