Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Codacy Analysis CLI Action #53

Merged
merged 5 commits into from
Apr 17, 2021

Conversation

Siddhant-K-code
Copy link
Contributor

Reference: #42 (comment)

@Siddhant-K-code
Copy link
Contributor Author

@anjalisoni3655 Please Review and Merge!

@anjalisoni3655 anjalisoni3655 merged commit 537ecbe into Open-Sourced-Olaf:main Apr 17, 2021
@Siddhant-K-code
Copy link
Contributor Author

there is some problem with this setup, file should be like this :

name: Codacy Security Scan

on:
  push:
    branches: [ "master", "main" ]
  pull_request:
    branches: [ "master", "main" ]

jobs:
  codacy-security-scan:
    name: Codacy Security Scan
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@main

      - name: Run Codacy Analysis CLI
        uses: codacy/codacy-analysis-cli-action@master
        with:
          output: results.sarif
          format: sarif
          # Adjust severity of non-security issues
          gh-code-scanning-compat: true
          # Force 0 exit code to allow SARIF file generation
          # This will handover control about PR rejection to the GitHub side
          max-allowed-issues: 2147483647
      
      # Upload the SARIF file generated in the previous step
      - name: Upload SARIF results file
        uses: github/codeql-action/upload-sarif@main
        with:
          sarif_file: results.sarif

because actions/checkout is no more using master, they are using main. Pls edit it if you can @anjalisoni3655

@anjalisoni3655
Copy link
Collaborator

there is some problem with this setup, file should be like this :

name: Codacy Security Scan

on:
  push:
    branches: [ "master", "main" ]
  pull_request:
    branches: [ "master", "main" ]

jobs:
  codacy-security-scan:
    name: Codacy Security Scan
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@main

      - name: Run Codacy Analysis CLI
        uses: codacy/codacy-analysis-cli-action@master
        with:
          output: results.sarif
          format: sarif
          # Adjust severity of non-security issues
          gh-code-scanning-compat: true
          # Force 0 exit code to allow SARIF file generation
          # This will handover control about PR rejection to the GitHub side
          max-allowed-issues: 2147483647
      
      # Upload the SARIF file generated in the previous step
      - name: Upload SARIF results file
        uses: github/codeql-action/upload-sarif@main
        with:
          sarif_file: results.sarif

because actions/checkout is no more using master, they are using main. Pls edit it if you can @anjalisoni3655

Can you please create an issue for this and raise a new PR. I couldn't run the checks before merging.

@Siddhant-K-code
Copy link
Contributor Author

creating new PR, let checks will be passed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants