fix: check baselayer sequence before rearranging #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
force-pushed
the
fix-window-in-bigpicture
branch
3 times, most recently
from
35c873b
to
3954cc4
Compare
- The current window setup codepath that's gated behind the check for XDG_CURRENT_DESKTOP and STEAM_MULTIPLE_XWAYLANDS didn't account for situations when umu-launcher is being used with unofficial gamescope session scripts within a non-Steam-deck environment. In those cases, both those variables would be set as those scripts would create 2 xwayland servers just like the Steam Deck gamescope session, causing the game window to not appear in the foreground as the launcher would rearrange the already correct baselayer sequence. While the current logic was incorrect, it highlighted an existing problem -- the launcher shouldn't always be assuming the sequence is incorrect and rearranging the baselayer order sequence only if the window atom exists. Instead, it should only be rearranging it when it needs to be.
R1kaB3rN
force-pushed
the
fix-window-in-bigpicture
branch
from
3954cc4
to
a02ffea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the window setup routine to only rearrange the value from the GAMESCOPECTRL_BASELAYER_APPID atom when it needs to be.
Closes #192 and tested on SteamOS 3.6.15 using Steam Version 1726683985 against a non-Steam game for potential regressions.
TODO: