Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BearerAuthInterceptor to dart-dio library exports #16960

Closed
wants to merge 2 commits into from

Conversation

dickermoshe
Copy link
Contributor

The BearerAuthInterceptor is missing from the generated library exports.
The other interceptors are included, so If we are exporting them, then it should be all or none

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Add missing export to dio template
@dickermoshe dickermoshe changed the title Update lib.mustache Add BearerAuthInterceptor to dart-dio library exports Nov 1, 2023
@wing328
Copy link
Member

wing328 commented Nov 1, 2023

thanks for the PR. did you follow step 3 to update the samples?

@dickermoshe
Copy link
Contributor Author

Yes.

@wing328
Copy link
Member

wing328 commented Nov 1, 2023

@dickermoshe
Copy link
Contributor Author

dickermoshe commented Nov 1, 2023

You're right, I ran it on dickermoshe/master instead of dickermoshe/patch-1.
I'll do that now. Sorry bout that.

@dickermoshe
Copy link
Contributor Author

dickermoshe commented Nov 1, 2023

@wing328 Please approve workflows

@SkylL3r
Copy link

SkylL3r commented Jul 3, 2024

Any update on this PR ?

@wing328
Copy link
Member

wing328 commented Jul 9, 2024

merged via #19111

@wing328 wing328 closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants