Radmap#3 #7
Merged
Radmap#3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements CommonKeypair, create_repo and get_repo
RangerMauve
requested changes
Aug 1, 2024
RangerMauve
requested changes
Sep 5, 2024
…nagement - Removed redundant `record_key` and `id` fields, utilizing `group.id()` to reference DHT record keys directly. - Simplified the process of storing keypairs and adding groups to the internal state by using `group.id()` for both. - Adjusted group initialization to remove unnecessary secret key handling, relying on DHTRecordDescriptor for this data.
- Removed redundant `id`, `record_key`, and `secret_key` fields from the Group struct. - Implemented `id()`, `owner_key()`, and `owner_secret()` getters to extract the necessary information directly from `dht_record`. - Simplified the `get_secret_key()` method to use `owner_secret()` instead of storing a separate secret key. - Streamlined the Group initialization process by removing unnecessary parameters related to key management.
…tor changes - Refactored test cases to reference Group by `TypedKey` instead of `record_key` and removed unused variables. - Replaced direct use of `group.get_id()` with `group.id()` getter. - Updated `TypedKey::new` calls to include `CRYPTO_KIND_VLD0` for correct key initialization. - Adjusted assertions to compare `group.id()` with retrieved keypair fields, ensuring proper key handling after refactor.
RangerMauve
requested changes
Sep 10, 2024
Tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring:
common.rslib.rs.Implemented features:
common.rsfile.Enhancements:
encryption_key.encryption_keyusesrandom_shared_secret.