Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge Pika-migrate into the tools directory of the unstable branch #2941

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 26 additions & 42 deletions .github/workflows/pika.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,51 +84,32 @@ jobs:
chmod +x integrate_test.sh
sh integrate_test.sh

build_on_rocky:

build_on_centos:
runs-on: ubuntu-latest
container:
image: rockylinux:9
image: cheniujh/pika-centos7-ci:v5

steps:
- name: Install deps
run: |
dnf update -y
dnf install -y bash cmake wget git autoconf gcc perl-Digest-SHA tcl which tar g++ tar epel-release gcc-c++ libstdc++-devel gcc-toolset-13

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.19

- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v1
with:
fetch-depth: 0

- name: Configure CMake
run: |
source /opt/rh/gcc-toolset-13/enable
cmake -B build -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DUSE_PIKA_TOOLS=ON -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address .

- uses: actions/cache@v3
with:
path: ${{ github.workspace }}/deps
key: ${{ runner.os }}-rocky-deps-${{ hashFiles('**/CMakeLists.txt') }}

- uses: actions/cache@v3
with:
path: ${{ github.workspace }}/buildtrees
key: ${{ runner.os }}-rocky-buildtrees-${{ hashFiles('**/CMakeLists.txt') }}
source /opt/rh/devtoolset-10/enable
cmake -B build -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DUSE_PIKA_TOOLS=ON -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address
Comment on lines +88 to +102
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Security and performance improvements needed in CentOS build job

Several issues need attention:

  1. Using actions/checkout@v1 is outdated. Update to v4 for security fixes and new features.
  2. Container image should be pinned to a specific SHA for reproducible builds.
  3. Consider adding ccache configuration like other jobs for faster builds.

Apply these changes:

  build_on_centos:
    runs-on: ubuntu-latest
    container:
-      image: cheniujh/pika-centos7-ci:v5
+      image: cheniujh/pika-centos7-ci@sha256:<hash>

    steps:
      - name: Checkout
-       uses: actions/checkout@v1
+       uses: actions/checkout@v4
        with:
          fetch-depth: 0

+     - name: ccache
+       uses: hendrikmuhs/[email protected]
+       with:
+         key: centos-7

Committable suggestion skipped: line range outside the PR's diff.


- name: Build
run: |
source /opt/rh/gcc-toolset-13/enable
source /opt/rh/devtoolset-10/enable
cmake --build build --config ${{ env.BUILD_TYPE }}

- name: Cleanup
run: |
rm -rf ./deps
rm -rf ./buildtrees
rm -rf ./buildtrees

- name: Test
working-directory: ${{ github.workspace }}/build
Expand All @@ -145,7 +126,6 @@ jobs:
../tests/integration/start_master_and_slave.sh
chmod +x ../tests/integration/start_codis.sh
../tests/integration/start_codis.sh

- name: Run Go E2E Tests
working-directory: ${{ github.workspace }}/build
run: |
Expand All @@ -155,8 +135,10 @@ jobs:
chmod +x integrate_test.sh
sh integrate_test.sh


build_on_macos:
runs-on: macos-12

runs-on: macos-13

steps:
- uses: actions/checkout@v4
Expand All @@ -169,7 +151,7 @@ jobs:
- name: ccache
uses: hendrikmuhs/[email protected]
with:
key: macos-12
key: macos-13

- name: Install Deps
run: |
Expand All @@ -188,8 +170,10 @@ jobs:

- name: Cleanup
run: |
rm -rf ./deps
rm -rf ./buildtrees
cp deps/lib/libz.1.dylib .
cp deps/lib/libz.1.dylib tests/integration/
rm -rf ./deps
rm -rf ./buildtree

- name: Test
working-directory: ${{ github.workspace }}/build
Expand All @@ -201,21 +185,21 @@ jobs:
./pikatests.sh all clean

- name: Start codis, pika master and pika slave
working-directory: ${{ github.workspace }}/build
working-directory: ${{ github.workspace }}
run: |
chmod +x ../tests/integration/start_master_and_slave.sh
../tests/integration/start_master_and_slave.sh
chmod +x ../tests/integration/start_codis.sh
../tests/integration/start_codis.sh
cd tests/integration/
chmod +x start_master_and_slave.sh
./start_master_and_slave.sh
chmod +x start_codis.sh
./start_codis.sh


- name: Run Go E2E Tests
working-directory: ${{ github.workspace }}/build
working-directory: ${{ github.workspace }}
run: |
cd ../tools/pika_keys_analysis/
go test -v ./...
cd ../../tests/integration/
cd tests/integration/
chmod +x integrate_test.sh
sh integrate_test.sh
# sh integrate_test.sh
Comment on lines +200 to +202
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Integration test is disabled

The integration test execution is commented out without explanation. This could allow untested changes to be merged.

Either:

  1. Remove the comment to re-enable the test:
-   #       sh integrate_test.sh
+          sh integrate_test.sh
  1. Or provide a clear explanation why the test is disabled and create a tracking issue to re-enable it.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
cd tests/integration/
chmod +x integrate_test.sh
sh integrate_test.sh
# sh integrate_test.sh
cd tests/integration/
chmod +x integrate_test.sh
sh integrate_test.sh


build_pika_image:
name: Build Pika Docker image
Expand Down
11 changes: 11 additions & 0 deletions .gitmodule
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[submodule "tools/pika_migrate/third/blackwidow"]
url = https://github.com/Qihoo360/blackwidow.git
[submodule "tools/pika_migrate/third/slash"]
url = https://github.com/Qihoo360/slash.git
[submodule "tools/pika_migrate/third/pink"]
url = https://github.com/Qihoo360/pink.git
[submodule "tools/pika_migrate/third/glog"]
url = https://github.com/Qihoo360/glog.git
[submodule "tools/pika_migrate/third/rocksdb"]
url = https://github.com/facebook/rocksdb.git

8 changes: 4 additions & 4 deletions codis/config/proxy.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ session_break_on_failure = false
# Slowlog-log-slower-than(us), from receive command to send response, 0 is allways print slow log
slowlog_log_slower_than = 100000

# quick command list e.g. get, set
quick_cmd_list = ""
# slow command list e.g. hgetall, mset
slow_cmd_list = ""
# quick command list
quick_cmd_list = "get,set"
# slow command list
slow_cmd_list = "mget, mset"

# Set metrics server (such as http://localhost:28000), proxy will report json formatted metrics to specified server in a predefined period.
metrics_report_server = ""
Expand Down
1 change: 1 addition & 0 deletions pikatests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function setup_pika_bin {
exit 1
fi
cp $PIKA_BIN src/redis-server
cp $PIKA_BIN tests/integration/pika
cp tests/conf/pika.conf tests/assets/default.conf
}

Expand Down
2 changes: 1 addition & 1 deletion src/pika_repl_bgworker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ void PikaReplBgWorker::WriteDBInSyncWay(const std::shared_ptr<Cmd>& c_ptr) {
if (duration > g_pika_conf->slowlog_slower_than()) {
g_pika_server->SlowlogPushEntry(argv, start_time, duration);
if (g_pika_conf->slowlog_write_errorlog()) {
LOG(ERROR) << "command: " << argv[0] << ", start_time(s): " << start_time << ", duration(us): " << duration;
LOG(INFO) << "command: " << argv[0] << ", start_time(s): " << start_time << ", duration(us): " << duration;
}
}
}
Expand Down
1 change: 1 addition & 0 deletions tools/pika_migrate/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
tests/* linguist-vendored
49 changes: 49 additions & 0 deletions tools/pika_migrate/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Compiled Object files
*.slo
*.lo
*.o
*.obj
*pb.cc
*pb.h

# Precompiled Headers
*.gch
*.pch

# Compiled Dynamic libraries
*.so
*.dylib
*.dll

# Fortran module files
*.mod

# Compiled Static libraries
*.lai
*.la
*.a
*.lib

# Executables
*.exe
*.out
*.app

# Log path
make_config.mk
log/
lib/
tools/
output/

# DB
db/
dump/

# third party
gdb.txt
tags

make_config.mk
src/*.d
src/build_version.cc
26 changes: 26 additions & 0 deletions tools/pika_migrate/.travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
sudo: required
dist: trusty
language: cpp

os:
- linux

env:
global:
- PROTOBUF_VERSION=2.5.0

install:
- wget https://github.com/protocolbuffers/protobuf/releases/download/v$PROTOBUF_VERSION/protobuf-$PROTOBUF_VERSION.tar.bz2
- tar xvf protobuf-$PROTOBUF_VERSION.tar.bz2
- ( cd protobuf-$PROTOBUF_VERSION && ./configure --prefix=/usr && make && sudo make install )

addons:
apt:
packages: ['libsnappy-dev', 'libprotobuf-dev', 'libgoogle-glog-dev']

compiler:
- gcc

language: cpp

script: make
46 changes: 46 additions & 0 deletions tools/pika_migrate/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
1 change: 1 addition & 0 deletions tools/pika_migrate/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
### Contributing to pika
21 changes: 21 additions & 0 deletions tools/pika_migrate/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
FROM centos:latest
MAINTAINER left2right <[email protected]>

RUN rpm -ivh https://mirrors.ustc.edu.cn/epel/epel-release-latest-7.noarch.rpm && \
yum -y update && \
yum -y install snappy-devel && \
yum -y install protobuf-devel && \
yum -y install gflags-devel && \
yum -y install glog-devel && \
yum -y install gcc-c++ && \
yum -y install make && \
yum -y install which && \
yum -y install git

ENV PIKA /pika
COPY . ${PIKA}
WORKDIR ${PIKA}
RUN make
ENV PATH ${PIKA}/output/bin:${PATH}

WORKDIR ${PIKA}/output
10 changes: 10 additions & 0 deletions tools/pika_migrate/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
The MIT License (MIT)

Copyright © 2018 <Qihoo360>

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Loading
Loading