-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Merge Pika-migrate into the tools directory of the unstable branch #2941
base: unstable
Are you sure you want to change the base?
Changes from all commits
b793d2d
69e8768
e12fe4e
ef8029b
c8f78fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -84,51 +84,32 @@ jobs: | |||||||||||||||
chmod +x integrate_test.sh | ||||||||||||||||
sh integrate_test.sh | ||||||||||||||||
|
||||||||||||||||
build_on_rocky: | ||||||||||||||||
|
||||||||||||||||
build_on_centos: | ||||||||||||||||
runs-on: ubuntu-latest | ||||||||||||||||
container: | ||||||||||||||||
image: rockylinux:9 | ||||||||||||||||
image: cheniujh/pika-centos7-ci:v5 | ||||||||||||||||
|
||||||||||||||||
steps: | ||||||||||||||||
- name: Install deps | ||||||||||||||||
run: | | ||||||||||||||||
dnf update -y | ||||||||||||||||
dnf install -y bash cmake wget git autoconf gcc perl-Digest-SHA tcl which tar g++ tar epel-release gcc-c++ libstdc++-devel gcc-toolset-13 | ||||||||||||||||
|
||||||||||||||||
- name: Set up Go | ||||||||||||||||
uses: actions/setup-go@v5 | ||||||||||||||||
with: | ||||||||||||||||
go-version: 1.19 | ||||||||||||||||
|
||||||||||||||||
- name: Checkout | ||||||||||||||||
uses: actions/checkout@v4 | ||||||||||||||||
uses: actions/checkout@v1 | ||||||||||||||||
with: | ||||||||||||||||
fetch-depth: 0 | ||||||||||||||||
|
||||||||||||||||
- name: Configure CMake | ||||||||||||||||
run: | | ||||||||||||||||
source /opt/rh/gcc-toolset-13/enable | ||||||||||||||||
cmake -B build -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DUSE_PIKA_TOOLS=ON -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address . | ||||||||||||||||
|
||||||||||||||||
- uses: actions/cache@v3 | ||||||||||||||||
with: | ||||||||||||||||
path: ${{ github.workspace }}/deps | ||||||||||||||||
key: ${{ runner.os }}-rocky-deps-${{ hashFiles('**/CMakeLists.txt') }} | ||||||||||||||||
|
||||||||||||||||
- uses: actions/cache@v3 | ||||||||||||||||
with: | ||||||||||||||||
path: ${{ github.workspace }}/buildtrees | ||||||||||||||||
key: ${{ runner.os }}-rocky-buildtrees-${{ hashFiles('**/CMakeLists.txt') }} | ||||||||||||||||
source /opt/rh/devtoolset-10/enable | ||||||||||||||||
cmake -B build -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DUSE_PIKA_TOOLS=ON -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address | ||||||||||||||||
|
||||||||||||||||
- name: Build | ||||||||||||||||
run: | | ||||||||||||||||
source /opt/rh/gcc-toolset-13/enable | ||||||||||||||||
source /opt/rh/devtoolset-10/enable | ||||||||||||||||
cmake --build build --config ${{ env.BUILD_TYPE }} | ||||||||||||||||
|
||||||||||||||||
- name: Cleanup | ||||||||||||||||
run: | | ||||||||||||||||
rm -rf ./deps | ||||||||||||||||
rm -rf ./buildtrees | ||||||||||||||||
rm -rf ./buildtrees | ||||||||||||||||
|
||||||||||||||||
- name: Test | ||||||||||||||||
working-directory: ${{ github.workspace }}/build | ||||||||||||||||
|
@@ -145,7 +126,6 @@ jobs: | |||||||||||||||
../tests/integration/start_master_and_slave.sh | ||||||||||||||||
chmod +x ../tests/integration/start_codis.sh | ||||||||||||||||
../tests/integration/start_codis.sh | ||||||||||||||||
|
||||||||||||||||
- name: Run Go E2E Tests | ||||||||||||||||
working-directory: ${{ github.workspace }}/build | ||||||||||||||||
run: | | ||||||||||||||||
|
@@ -155,8 +135,10 @@ jobs: | |||||||||||||||
chmod +x integrate_test.sh | ||||||||||||||||
sh integrate_test.sh | ||||||||||||||||
|
||||||||||||||||
|
||||||||||||||||
build_on_macos: | ||||||||||||||||
runs-on: macos-12 | ||||||||||||||||
|
||||||||||||||||
runs-on: macos-13 | ||||||||||||||||
|
||||||||||||||||
steps: | ||||||||||||||||
- uses: actions/checkout@v4 | ||||||||||||||||
|
@@ -169,7 +151,7 @@ jobs: | |||||||||||||||
- name: ccache | ||||||||||||||||
uses: hendrikmuhs/[email protected] | ||||||||||||||||
with: | ||||||||||||||||
key: macos-12 | ||||||||||||||||
key: macos-13 | ||||||||||||||||
|
||||||||||||||||
- name: Install Deps | ||||||||||||||||
run: | | ||||||||||||||||
|
@@ -188,8 +170,10 @@ jobs: | |||||||||||||||
|
||||||||||||||||
- name: Cleanup | ||||||||||||||||
run: | | ||||||||||||||||
rm -rf ./deps | ||||||||||||||||
rm -rf ./buildtrees | ||||||||||||||||
cp deps/lib/libz.1.dylib . | ||||||||||||||||
cp deps/lib/libz.1.dylib tests/integration/ | ||||||||||||||||
rm -rf ./deps | ||||||||||||||||
rm -rf ./buildtree | ||||||||||||||||
|
||||||||||||||||
- name: Test | ||||||||||||||||
working-directory: ${{ github.workspace }}/build | ||||||||||||||||
|
@@ -201,21 +185,21 @@ jobs: | |||||||||||||||
./pikatests.sh all clean | ||||||||||||||||
|
||||||||||||||||
- name: Start codis, pika master and pika slave | ||||||||||||||||
working-directory: ${{ github.workspace }}/build | ||||||||||||||||
working-directory: ${{ github.workspace }} | ||||||||||||||||
run: | | ||||||||||||||||
chmod +x ../tests/integration/start_master_and_slave.sh | ||||||||||||||||
../tests/integration/start_master_and_slave.sh | ||||||||||||||||
chmod +x ../tests/integration/start_codis.sh | ||||||||||||||||
../tests/integration/start_codis.sh | ||||||||||||||||
cd tests/integration/ | ||||||||||||||||
chmod +x start_master_and_slave.sh | ||||||||||||||||
./start_master_and_slave.sh | ||||||||||||||||
chmod +x start_codis.sh | ||||||||||||||||
./start_codis.sh | ||||||||||||||||
|
||||||||||||||||
|
||||||||||||||||
- name: Run Go E2E Tests | ||||||||||||||||
working-directory: ${{ github.workspace }}/build | ||||||||||||||||
working-directory: ${{ github.workspace }} | ||||||||||||||||
run: | | ||||||||||||||||
cd ../tools/pika_keys_analysis/ | ||||||||||||||||
go test -v ./... | ||||||||||||||||
cd ../../tests/integration/ | ||||||||||||||||
cd tests/integration/ | ||||||||||||||||
chmod +x integrate_test.sh | ||||||||||||||||
sh integrate_test.sh | ||||||||||||||||
# sh integrate_test.sh | ||||||||||||||||
Comment on lines
+200
to
+202
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Integration test is disabled The integration test execution is commented out without explanation. This could allow untested changes to be merged. Either:
- # sh integrate_test.sh
+ sh integrate_test.sh
📝 Committable suggestion
Suggested change
|
||||||||||||||||
|
||||||||||||||||
build_pika_image: | ||||||||||||||||
name: Build Pika Docker image | ||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[submodule "tools/pika_migrate/third/blackwidow"] | ||
url = https://github.com/Qihoo360/blackwidow.git | ||
[submodule "tools/pika_migrate/third/slash"] | ||
url = https://github.com/Qihoo360/slash.git | ||
[submodule "tools/pika_migrate/third/pink"] | ||
url = https://github.com/Qihoo360/pink.git | ||
[submodule "tools/pika_migrate/third/glog"] | ||
url = https://github.com/Qihoo360/glog.git | ||
[submodule "tools/pika_migrate/third/rocksdb"] | ||
url = https://github.com/facebook/rocksdb.git | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
tests/* linguist-vendored |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Compiled Object files | ||
*.slo | ||
*.lo | ||
*.o | ||
*.obj | ||
*pb.cc | ||
*pb.h | ||
|
||
# Precompiled Headers | ||
*.gch | ||
*.pch | ||
|
||
# Compiled Dynamic libraries | ||
*.so | ||
*.dylib | ||
*.dll | ||
|
||
# Fortran module files | ||
*.mod | ||
|
||
# Compiled Static libraries | ||
*.lai | ||
*.la | ||
*.a | ||
*.lib | ||
|
||
# Executables | ||
*.exe | ||
*.out | ||
*.app | ||
|
||
# Log path | ||
make_config.mk | ||
log/ | ||
lib/ | ||
tools/ | ||
output/ | ||
|
||
# DB | ||
db/ | ||
dump/ | ||
|
||
# third party | ||
gdb.txt | ||
tags | ||
|
||
make_config.mk | ||
src/*.d | ||
src/build_version.cc |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
sudo: required | ||
dist: trusty | ||
language: cpp | ||
|
||
os: | ||
- linux | ||
|
||
env: | ||
global: | ||
- PROTOBUF_VERSION=2.5.0 | ||
|
||
install: | ||
- wget https://github.com/protocolbuffers/protobuf/releases/download/v$PROTOBUF_VERSION/protobuf-$PROTOBUF_VERSION.tar.bz2 | ||
- tar xvf protobuf-$PROTOBUF_VERSION.tar.bz2 | ||
- ( cd protobuf-$PROTOBUF_VERSION && ./configure --prefix=/usr && make && sudo make install ) | ||
|
||
addons: | ||
apt: | ||
packages: ['libsnappy-dev', 'libprotobuf-dev', 'libgoogle-glog-dev'] | ||
|
||
compiler: | ||
- gcc | ||
|
||
language: cpp | ||
|
||
script: make |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Contributor Covenant Code of Conduct | ||
|
||
## Our Pledge | ||
|
||
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation. | ||
|
||
## Our Standards | ||
|
||
Examples of behavior that contributes to creating a positive environment include: | ||
|
||
* Using welcoming and inclusive language | ||
* Being respectful of differing viewpoints and experiences | ||
* Gracefully accepting constructive criticism | ||
* Focusing on what is best for the community | ||
* Showing empathy towards other community members | ||
|
||
Examples of unacceptable behavior by participants include: | ||
|
||
* The use of sexualized language or imagery and unwelcome sexual attention or advances | ||
* Trolling, insulting/derogatory comments, and personal or political attacks | ||
* Public or private harassment | ||
* Publishing others' private information, such as a physical or electronic address, without explicit permission | ||
* Other conduct which could reasonably be considered inappropriate in a professional setting | ||
|
||
## Our Responsibilities | ||
|
||
Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior. | ||
|
||
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers. | ||
|
||
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately. | ||
|
||
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership. | ||
|
||
## Attribution | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version] | ||
|
||
[homepage]: http://contributor-covenant.org | ||
[version]: http://contributor-covenant.org/version/1/4/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
### Contributing to pika |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
FROM centos:latest | ||
MAINTAINER left2right <[email protected]> | ||
|
||
RUN rpm -ivh https://mirrors.ustc.edu.cn/epel/epel-release-latest-7.noarch.rpm && \ | ||
yum -y update && \ | ||
yum -y install snappy-devel && \ | ||
yum -y install protobuf-devel && \ | ||
yum -y install gflags-devel && \ | ||
yum -y install glog-devel && \ | ||
yum -y install gcc-c++ && \ | ||
yum -y install make && \ | ||
yum -y install which && \ | ||
yum -y install git | ||
|
||
ENV PIKA /pika | ||
COPY . ${PIKA} | ||
WORKDIR ${PIKA} | ||
RUN make | ||
ENV PATH ${PIKA}/output/bin:${PATH} | ||
|
||
WORKDIR ${PIKA}/output |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
The MIT License (MIT) | ||
|
||
Copyright © 2018 <Qihoo360> | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security and performance improvements needed in CentOS build job
Several issues need attention:
actions/checkout@v1
is outdated. Update to v4 for security fixes and new features.Apply these changes: