-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent ]Issue/1860 windows install script #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review, need to test the session install and the 2 upgrades
7a14951
to
cf315c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about creating a README on the installer folder and writing that if we update a script, don't forget to update all other scripts ?
Sorry, some tests aren't OK :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK :)
Proposed changes
For testing the service user:
makensis agent-installer-service-user.nsi
.\agent-installer-service-user.exe /S ~USER=[username with domain] ~PASSWORD=[password] ~OPENBAS_URL="http://localhost:3001" ~ACCESS_TOKEN="5ccddea0-613c-4a91-a602-6a4eb243d21c" ~UNSECURED_CERTIFICATE=false ~WITH_PROXY=false
powershell agent-installer-service-user.ps1 -User [username with domain] -Password [password]
For testing the session:
makensis agent-installer-session-user.nsi
.\agent-installer-session-user.exe /S ~OPENBAS_URL="http://localhost:3001" ~ACCESS_TOKEN="5ccddea0-613c-4a91-a602-6a4eb243d21c" ~UNSECURED_CERTIFICATE=false ~WITH_PROXY=false WITH_ADMIN_PRIVILEGE=[true or false]
powershell agent-installer-session-user.ps1 [-WithAdminPrivilege]
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...