Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add tests to Environment.exportData (#1489) #2210

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Jan 14, 2025

Proposed changes

  • Adding unit tests to Environment.exportData

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

This is just focused on the actual function that flattens objects in a collection into Excel-able structures (i.e. flat objects). This function only special-cases a few specific keys in a candidate object though.
This is part of the XLS aspect of the linked issue.

@antoinemzs antoinemzs changed the base branch from master to issue/1489_tests January 14, 2025 19:49
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.73%. Comparing base (13d6e1b) to head (1e53864).
Report is 7 commits behind head on release/current.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/current    #2210   +/-   ##
==================================================
  Coverage              33.73%   33.73%           
  Complexity              1566     1566           
==================================================
  Files                    583      583           
  Lines                  18000    18000           
  Branches                1168     1168           
==================================================
  Hits                    6072     6072           
  Misses                 11635    11635           
  Partials                 293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinemzs antoinemzs changed the title Issue/1489 test export xls [frontend] Add tests to Environment.exportData (#1489) Jan 15, 2025
@antoinemzs antoinemzs marked this pull request as ready for review January 15, 2025 08:05
.circleci/config.yml Outdated Show resolved Hide resolved
Base automatically changed from issue/1489_tests to release/current January 20, 2025 13:42
@antoinemzs antoinemzs force-pushed the issue/1489_test_export_xls branch from 129a70d to 6e8de3a Compare January 20, 2025 14:07
antoinemzs and others added 9 commits January 20, 2025 15:31
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs force-pushed the issue/1489_test_export_xls branch from f5abfe2 to 1e53864 Compare January 20, 2025 14:31
@antoinemzs antoinemzs merged commit 760dfb8 into release/current Jan 21, 2025
6 checks passed
@antoinemzs antoinemzs deleted the issue/1489_test_export_xls branch January 21, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Unit testing - simulation scope ] - import/export of a simulation (JSON)
2 participants