[backend] Account for all relevant pauses in inject start date computation (#2282) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinemzs
force-pushed
the
fix/armasuisse_pause_bug
branch
from
5444f43 to
7e8a1c8
Compare
antoinemzs
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/current #2319 +/- ##
=====================================================
+ Coverage 37.93% 38.08% +0.15%
- Complexity 1778 1782 +4
=====================================================
Files 596 596
Lines 18274 18274
Branches 1214 1214
=====================================================
+ Hits 6932 6960 +28
+ Misses 10984 10956 -28
Partials 358 358 ☔ View full report in Codecov by Sentry. |
antoinemzs
commented
Jan 29, 2025
Comment on lines
17
to
23
| statement.execute( | ||
| """ | ||
| ALTER TABLE exercises ADD COLUMN exercise_pause_date_tempwithtz TIMESTAMP WITH TIME ZONE; | ||
| UPDATE exercises SET exercise_pause_date_tempwithtz = exercise_pause_date; | ||
| ALTER TABLE exercises DROP COLUMN exercise_pause_date; | ||
| ALTER TABLE exercises RENAME COLUMN exercise_pause_date_tempwithtz TO exercise_pause_date; | ||
| """); |
There was a problem hiding this comment.
There's no migration of existing data (i.e. recompute of timestamps) because I lack information on the relevant timezone that originated the Instant.
But it's not really important as it only affects currently paused simulations and would not impact them further. Assumed TZ after migration is UTC.
antoinemzs
force-pushed
the
fix/armasuisse_pause_bug
branch
from
ea06e84 to
77f3544
Compare
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
antoinemzs
force-pushed
the
fix/armasuisse_pause_bug
branch
from
77f3544 to
0ce24c3
Compare
guillaumejparis
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
Tests are better implemented with composers hence I propose this PR to release branch. Another PR with just the code fix is going to master.
There's a drive-by fix on the schema because current pause was being persisted assuming the provided instant was local time, when in reality it was provided as UTC => the backend would compute an incorrect UTC time to persist. It was low impact but needed to be addressed.