fix: Parse YDS slash grades correctly #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YDS slash grades were being assigned the score of the first grade. This was due to `.includes()` not matching the slash. Change this to correctly identify slash grades. Refactor a little to help clarity. Add test that score range of a slash grade is strict subset of that of the two grades, and overlaps with both of them. Add failing tests slash grades composed of non-consecutive grades and slashes across number boundaries. Fixes OpenBeta#142
musoke
added a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
musoke
added a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
musoke
added a commit
to OpenBeta/open-tacos
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
6 tasks
vnugent
pushed a commit
to OpenBeta/open-tacos
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
vnugent
pushed a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 3, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
l4u532
pushed a commit
to l4u532/openbeta-graphql
that referenced
this pull request
Aug 23, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YDS slash grades were being assigned the score of the first grade. This was due to
.includes()not matching the slash.Change this to correctly identify slash grades. Refactor a little to help clarity.
Add test that score range of a slash grade is strict subset of that of the two grades, and overlaps with both of them.
Add failing tests slash grades composed of non-consecutive grades and slashes across number boundaries.
Fixes #142